[Trimming][Windows] Simplify ActivityIndicator foreground color setting #21230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
How about this one? |
Member
Author
|
@PureWeen I'll close this PR in favor of yours |
simonrozsival
deleted the
remove-winui-activity-indicator-restore-foreground-color-workaround
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The GetField and GetFields methods in ReflectionExtensions weren't trimming safe, at least not the way we used them from the Windows-specific code. It seems that these methods and most of the
FrameworkElementExtensionsis not needed and is too complicated for what it does.This code isn't tested very well yet so it is a Draft for now. There's no need to spend time reviewing it at the moment :)
Issues Fixed
Related to #21076