Rework foreground color and remove outdated methods #21238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested review from
mattleibow and
simonrozsival
and removed request for
StephaneDelcroix and
tj-devel709
Member
|
@PureWeen there are two more |
Member
Author
I deleted the extra one in the controls project that wasn't doing anything. If anyone is using the compatibility project bits they aren't going to be AOT successful |
simonrozsival
approved these changes
Mar 21, 2024
rmarinho
approved these changes
Mar 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The foreground color update code used for ActivityIndicator is about 10 years old and doesn't match up with any of our current techniques. This PR updates to a better version of updating/resetting AI defaults so we don't have to depend on reflection