Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
iOS doesn't have the ability to garbage collect if there's a circular reference of NSObjects. In order for the GC to work, it's important for platform views to only reference down the tree and never up the tree.
This PR makes it so the
Parent
property on our xplat element is just using a WeakReference so that there isn't a strong reference from the children back up to the parents.This shouldn't cause any issues with the
Parent
orChild
being collected prematurely for a couple of reasons.