-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blazor] Account for Maui multi-rid builds #9348
[Blazor] Account for Maui multi-rid builds #9348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall think this is a fine short-term fix, until there is some multi-RID build support in the .NET SDK.
<Target Name="_AdjustStaticWebAssetPathBaseWhenBuildingWithRid" BeforeTargets="ResolveStaticWebAssetsConfiguration" Condition="'$(_OuterIntermediateOutputPath)' != ''"> | ||
<PropertyGroup> | ||
<_StaticWebAssetsManifestBase>$(_OuterIntermediateOutputPath)</_StaticWebAssetsManifestBase> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good this checks if $(_OuterIntermediateOutputPath)
is blank. Since it's "private", prefixed with underscore, someone might delete/rename this in the future.
We're looking to backport dotnet/sdk#27108 (Intermediate output changes) to 6.0.4xx. Do we need to backport this PR as well, or is it fine as-is given |
/cc @mattleibow I believe you need this change on |
/backport to release/6.0.4xx |
I'm not seeing any changes in that branch since June (https://github.com/dotnet/maui/commits/release/6.0.4xx) just wondering if that's expected or perhaps this needs to go to another branch? |
Yes, I'm not sure how their branches are setup, maybe it's actually |
yeah, net6.0 |
(cherry picked from commit ef5e813)
Created #9393. |
Microsoft.Android.Sdk.AssemblyResolution.targets _ResolveAssemblies triggers a nested build to resolve publish files in a Maui specific way and that breaks elements depending on the '$(IntermediateOutputPath)'.
This target detects we are running inside one of such builds and adjust the relevant paths.