Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 6 Fix .NET MAUI Blazor Scoped CSS Hot Reload #27108

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Aug 11, 2022

Fixes: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1589099

Description

Scoped CSS Hot Reload doesn't work for .NET 6.0 MAUI Blazor apps, this is part one of a two part fix which resolves this issue in .NET 6.

Original Issue: #26762
VSTS issue requesting backport: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1589099

Backports:

Will also need: dotnet/maui#9348 -> dotnet/maui#9393

Customer Impact

Hot reload of scoped CSS fails for .NET 6.0 MAUI Blazor applications without this (and the complementary dotnet/maui) change.

Regression?

  • Yes
  • No

Computation of these values were moved to a target resulting in this regression.

Risk

  • High
  • Medium
  • Low

Low risk, we've already made these changes in main/net7.

Verification

  • Manual (required)
  • Automated

It was done a different way because a while ago we were computing the path inside a global PropertyGroup and when we changed it to be computed inside a target, we didn't change it to just rely on the IntermediateOutputPath.

(cherry picked from commit ab4d89f)
…if defined by the environment (#27102)

(cherry picked from commit bcb1cd2)
@TanayParikh TanayParikh requested a review from javiercn August 11, 2022 18:52
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@TanayParikh TanayParikh added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Aug 11, 2022
@TanayParikh TanayParikh added this to the 6.0.4xx milestone Aug 11, 2022
@TanayParikh TanayParikh changed the title Backport razor sdk path changes Backport Razor Static Web Assets Manifest Path Changes Aug 11, 2022
@TanayParikh TanayParikh marked this pull request as ready for review August 12, 2022 17:22
@TanayParikh
Copy link
Contributor Author

Companion PR: dotnet/maui#9393

@TanayParikh
Copy link
Contributor Author

TanayParikh commented Aug 15, 2022

@dougbu @wtgodbe do you happen to know if we're okay to merge, or must this go through tactics?

@wtgodbe
Copy link
Member

wtgodbe commented Aug 15, 2022

Seems fine as a tell-mode PR to me.

@TanayParikh
Copy link
Contributor Author

Seems fine as a tell-mode PR to me.

Sounds good, thanks! cc/ @marcpopMSFT in case you have any concerns :)

(Not seeing a tell-mode label so not annotating anything).

@marcpopMSFT
Copy link
Member

Tell mode is generally used for infrastructure changes and test changes. Isn't this a change to the customer-facing razor targets?

@TanayParikh
Copy link
Contributor Author

Tell mode is generally used for infrastructure changes and test changes. Isn't this a change to the customer-facing razor targets?

Yes these targets will have direct customer impact. This is required to help resolve https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1589099 which is causing hot reload failures in .NET 6. We'll be merging this in conjunction with dotnet/maui#9393.

@marcpopMSFT what would you suggest the appropriate process be in that case? Ask mode (ask you?) or would it be through tactics + servicing template?

@marcpopMSFT
Copy link
Member

Since there is direct customer impact, I would mark servicing-consider, update the description with the template (look for other servicing-approved bugs for the template), and send mail to tactics.

@TanayParikh TanayParikh changed the title Backport Razor Static Web Assets Manifest Path Changes .NET 6 Fix .NET MAUI Blazor Scoped CSS Hot Reload Aug 15, 2022
@marcpopMSFT
Copy link
Member

@TanayParikh @mkArtakMSFT @javiercn pinged offline as well but if this is needed for servicing, it should be merged today.

@TanayParikh TanayParikh merged commit 973a1e3 into release/6.0.4xx Aug 16, 2022
@TanayParikh TanayParikh deleted the backportRazorSDKPathChanges branch August 16, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch Servicing-approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants