-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET 6 Fix .NET MAUI Blazor Scoped CSS Hot Reload #27108
Conversation
It was done a different way because a while ago we were computing the path inside a global PropertyGroup and when we changed it to be computed inside a target, we didn't change it to just rely on the IntermediateOutputPath. (cherry picked from commit ab4d89f)
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Companion PR: dotnet/maui#9393 |
Seems fine as a tell-mode PR to me. |
Sounds good, thanks! cc/ @marcpopMSFT in case you have any concerns :) (Not seeing a |
Tell mode is generally used for infrastructure changes and test changes. Isn't this a change to the customer-facing razor targets? |
Yes these targets will have direct customer impact. This is required to help resolve https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1589099 which is causing hot reload failures in .NET 6. We'll be merging this in conjunction with dotnet/maui#9393. @marcpopMSFT what would you suggest the appropriate process be in that case? Ask mode (ask you?) or would it be through tactics + servicing template? |
Since there is direct customer impact, I would mark servicing-consider, update the description with the template (look for other servicing-approved bugs for the template), and send mail to tactics. |
@TanayParikh @mkArtakMSFT @javiercn pinged offline as well but if this is needed for servicing, it should be merged today. |
Fixes: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1589099
Description
Scoped CSS Hot Reload doesn't work for .NET 6.0 MAUI Blazor apps, this is part one of a two part fix which resolves this issue in .NET 6.
Original Issue: #26762
VSTS issue requesting backport: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1589099
Backports:
Will also need: dotnet/maui#9348 -> dotnet/maui#9393
Customer Impact
Hot reload of scoped CSS fails for .NET 6.0 MAUI Blazor applications without this (and the complementary dotnet/maui) change.
Regression?
Computation of these values were moved to a target resulting in this regression.
Risk
Low risk, we've already made these changes in main/net7.
Verification