[Blazor] Update the base path to use IntermediateOutputPath #26765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
Area-AspNetCore
mcumming
approved these changes
Jul 25, 2022
SteveSandersonMS
approved these changes
Jul 25, 2022
|
@SteveSandersonMS thanks. It was done a different way because a while ago we were computing the path inside a global PropertyGroup and when we changed it to be computed inside a target (as it should have been done from the beginning) we (I) didn't clean it up to just rely on the IntermediateOutputPath. Pretty much every test covers this scenario, which is a good indication that nothing has changed. The part where this will help a bit is on the Maui side, where the platform wasn't being included on the output. However, it is a bit complicated to author a test for that here. |
|
/backport to release/6.0.4xx |
TanayParikh
pushed a commit
that referenced
this pull request
Aug 11, 2022
It was done a different way because a while ago we were computing the path inside a global PropertyGroup and when we changed it to be computed inside a target, we didn't change it to just rely on the IntermediateOutputPath. (cherry picked from commit ab4d89f)
7 tasks
TanayParikh
added a commit
that referenced
this pull request
Aug 16, 2022
* [Blazor] Update the base path to use IntermediateOutputPath (#26765) It was done a different way because a while ago we were computing the path inside a global PropertyGroup and when we changed it to be computed inside a target, we didn't change it to just rely on the IntermediateOutputPath. (cherry picked from commit ab4d89f) * [Blazor] Allow customizing the static web assets base manifest paths if defined by the environment (#27102) (cherry picked from commit bcb1cd2) Co-authored-by: Javier Calvarro Nelson <jacalvar@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can rely on IntermediateOutputPath here since we moved computing these values to a target.
Fixes #26762