Ensure green test runs in VS #8329
Labels
Area: Our Own Build
Problems affecting the build or build infrastructure of the MSBuild repo itself.
backlog
bug
Priority:3
Work that is nice to have
triaged
Comments
JanKrivanek
added
bug
needs-triage
|
#8328 as inspiration for proper conditional skipping of tests |
Just wanted to mention that some of these issues reproduce on the command line as well. For example, |
It seems Visual Studio ignores those attributes Visual Studio shows them as I'm not sure whether this is a problem in how VS handling traits, or this is expected UX in VS, imo custom theory / fact attributes seems better solution as they work in VS and cmd and CI equally. |
|
Not related to VS Run, but when running test of x64: |
|
#8348 solves # 2, 3 and 4 in the list, and likely other cases as well. The Unix only cases will be skipped in VS now, as the tests running on unsupported framework. This should reduce number of red tests in VS. |
JaynieBai
pushed a commit
that referenced
this issue
Feb 8, 2023
Fixes #7330 (plus one subtask of #8329) Tests only change (no production code affected) Context Drive enumeration integration tests need to simulate attempt to enumerate whole drive. To prevent security and test runtime considerations - a dummy folder is created and mapped to a free letter to be offered to test as a drive for enumeration. Changes Made Added utility for mapping drives and mounted to affected unit tests.
|
Tests which are still failing: |
|
Related issue: #8457 |
AR-May
added
backlog
Area: Our Own Build
JaynieBai
added a commit
that referenced
this issue
Oct 10, 2023
Fixes #7330 (plus one subtask of #8329) Changes Made Based on Add ability to create temp mapped drive for integration tests #8366 fixes to enable other Drive enumeration integration tests with a dummy folder in windows Remove one test data https://github.com/dotnet/msbuild/blob/fecef0fdffe59ba8b0251701a23be48bbd552726/src/Build.OM.UnitTests/Instance/ProjectItemInstance_Tests.cs#L1010-L1012C45 since there is no warning when inlude is not null and exclude with enumerating wildcards. The related logical code is msbuild/src/Build/Utilities/EngineFileUtilities.cs Line 339 in fecef0f private static void LogDriveEnumerationWarningWithTargetLoggingContext(TargetLoggingContext targetLoggingContext, IElementLocation includeLocation, IElementLocation excludeLocation, bool excludeFileSpecIsEmpty, bool disableExcludeDriveEnumerationWarning, string fileSpec) . There is no condition satisfied. Associate unix Enumeration Tests long time run with issue Unix drive enumeration imports not expanded? #8373
bulatgrzegorz
pushed a commit
to bulatgrzegorz/selective-condition-evaluator
that referenced
this issue
Oct 16, 2023
Fixes dotnet#7330 (plus one subtask of dotnet#8329) Changes Made Based on Add ability to create temp mapped drive for integration tests dotnet#8366 fixes to enable other Drive enumeration integration tests with a dummy folder in windows Remove one test data https://github.com/dotnet/msbuild/blob/fecef0fdffe59ba8b0251701a23be48bbd552726/src/Build.OM.UnitTests/Instance/ProjectItemInstance_Tests.cs#L1010-L1012C45 since there is no warning when inlude is not null and exclude with enumerating wildcards. The related logical code is msbuild/src/Build/Utilities/EngineFileUtilities.cs Line 339 in fecef0f private static void LogDriveEnumerationWarningWithTargetLoggingContext(TargetLoggingContext targetLoggingContext, IElementLocation includeLocation, IElementLocation excludeLocation, bool excludeFileSpecIsEmpty, bool disableExcludeDriveEnumerationWarning, string fileSpec) . There is no condition satisfied. Associate unix Enumeration Tests long time run with issue Unix drive enumeration imports not expanded? dotnet#8373
MichalPavlik
pushed a commit
that referenced
this issue
Oct 17, 2023
Fixes #7330 (plus one subtask of #8329) Changes Made Based on Add ability to create temp mapped drive for integration tests #8366 fixes to enable other Drive enumeration integration tests with a dummy folder in windows Remove one test data https://github.com/dotnet/msbuild/blob/fecef0fdffe59ba8b0251701a23be48bbd552726/src/Build.OM.UnitTests/Instance/ProjectItemInstance_Tests.cs#L1010-L1012C45 since there is no warning when inlude is not null and exclude with enumerating wildcards. The related logical code is msbuild/src/Build/Utilities/EngineFileUtilities.cs Line 339 in fecef0f private static void LogDriveEnumerationWarningWithTargetLoggingContext(TargetLoggingContext targetLoggingContext, IElementLocation includeLocation, IElementLocation excludeLocation, bool excludeFileSpecIsEmpty, bool disableExcludeDriveEnumerationWarning, string fileSpec) . There is no condition satisfied. Associate unix Enumeration Tests long time run with issue Unix drive enumeration imports not expanded? #8373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Description
Running unit tests in VS leads to some test failures - this should not be a case. VS-centric developer workflow should not be neglected
Classes of problems to tackle:
ExecMSBuildfail on core: Unit test failures when run from VS #8313BuildEnvironmentHelper_Testsfail on core (extra RID in path) - Replacing traits used to skip certain test cases with customTheoryandFactattributes #8348TestPlatforms.AnyUnixrun on Windows (and can fail). Can we use Need ability to skip test programmatically xunit/xunit#2073 here? - Replacing traits used to skip certain test cases with customTheoryandFactattributes #8348SkipOnTargetFrameworkrun on excluded FW (and can fail) Can we use Need ability to skip test programmatically xunit/xunit#2073 here? - Replacing traits used to skip certain test cases with customTheoryandFactattributes #8348RetainsLastStringWithGivenHashCode: Fix .NET 3.5 InternableString.GetHashCode to match the full implementation #8340ProjectItemSpecTooLong(might be env setup on my machine) - related? MSBuild task tests fail when long-paths enabled #4247ProjectGetterResultsInWindowsDriveEnumerationWarningon Win (might be path specific?) - fixed by Allow MSBuild tests to access root of drive #7330LogWarningUponProjectInstanceCreationFromDriveEnumeratingContent&LogWindowsWarningUponProjectInstanceCreationFromDriveEnumeratingContent(env specific?) - Allow MSBuild tests to access root of drive #7330EvaluationProfiler_Tests(all) - no repro. (might have been caused by the bug in not unsetting the reverted change waves in tests)LogWindowsWarningUponBuildingProjectWithDriveEnumeration- likely just needs application of the following fix: Add ability to create temp mapped drive for integration tests #8366The text was updated successfully, but these errors were encountered: