Fix .NET 3.5 InternableString.GetHashCode to match the full implementation #8340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
approved these changes
Jan 23, 2023
rainersigwald
approved these changes
Jan 23, 2023
danmoseley
reviewed
Jan 23, 2023
Forgind
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of 8329
Context
The 3.5 version of
InternableStringuses a simpler hash code calculation, the results of which were not matching the 4.72/Core version. This manifested as a failing unit testRetainsLastStringWithGivenHashCodein VS.Changes Made
Made the routine return the same numbers as the other implementation. It fixed the UT and also made the hash code "better" as previously we were shifting instead of rotating bits.
Testing
Existing unit tests (previously failing).
Notes
It would be nice to figure out how to run 3.5 tests in CI.