Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Terminal Logger: Misaligned duration in long-running tasks #9562

Closed
ladipro opened this issue Dec 19, 2023 · 1 comment
Closed

[Bug]: Terminal Logger: Misaligned duration in long-running tasks #9562

ladipro opened this issue Dec 19, 2023 · 1 comment
Assignees
Labels
bug needs-triage Have yet to determine what bucket this goes in.

Comments

@ladipro
Copy link
Member

ladipro commented Dec 19, 2023

Issue Description

When the project build duration crosses the 10 (100, 1000, ...) second mark, the position of the task name does not compensate and appears misaligned or overwritten.

image

Steps to Reproduce

Build a project with a long-running task:

<Project>
  <Target Name='Build'>
    <Exec Command="ping -n 1111 127.0.0.1" />
  </Target>
</Project>

Expected Behavior

When crossing orders of magnitude, the task name shifts accordingly to make space for more digits of duration.

Build (9.0s)
Build (99.0s)
Build (999.0s)

Actual Behavior

When crossing orders of magnitude, the position of the task name stays the same.

Build (9.0s)
Build(99.0s)
Buil(999.0s)

Analysis

No response

Versions & Configurations

MSBuild version 17.10.0-dev-23619-01+5cf78584f

@ladipro ladipro added bug needs-triage Have yet to determine what bucket this goes in. labels Dec 19, 2023
@rainersigwald rainersigwald self-assigned this Dec 19, 2023
rainersigwald added a commit to rainersigwald/msbuild that referenced this issue Dec 19, 2023
Fixes dotnet#9562 by triggering a full-line redraw when the length of the duration string increases.
@ladipro
Copy link
Member Author

ladipro commented Dec 19, 2023

s/task/target/g in the title and issue description 🤦‍♂️ Thank you for the fast turnaround!

rainersigwald added a commit to rainersigwald/msbuild that referenced this issue Dec 20, 2023
Fixes dotnet#9562 by triggering a full-line redraw when the length of the duration string increases.
@AR-May AR-May closed this as completed in a1ad6b8 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-triage Have yet to determine what bucket this goes in.
Projects
None yet
Development

No branches or pull requests

2 participants