-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When time increases by a digit, overwrite NodeStatus #9563
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
Forgind
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
ladipro
approved these changes
Dec 20, 2023
Fixes dotnet#9562 by triggering a full-line redraw when the length of the duration string increases.
Without these, the total build elapsed time was surprisingly high (from a timestamp-0 base).
Based on https://github.com/VerifyTests/Verify/blob/52606c47a07b0c10e53fcfa9809a4e5eb181f51a/docs/wiz/Linux_Other_Cli_xUnit_AzureDevOps.md#getting-received-in-output-on-azure-devops * Add double quotes around echo argument * Use forward slash on *nix Co-authored-by: Ladi Prosek <laprosek@microsoft.com>
rainersigwald
force-pushed
the
tl-digit-muncher
branch
from
December 20, 2023 11:45
6b42db2
to
9c0df3c
Compare
Co-authored-by: Ladi Prosek <ladi.prosek@gmail.com>
rainersigwald
force-pushed
the
tl-digit-muncher
branch
from
December 20, 2023 11:51
e32c402
to
ef18b60
Compare
AR-May
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9562 by triggering a full-line redraw when the length of the duration string increases.
long-running.duration.pushes.left.mp4