Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When time increases by a digit, overwrite NodeStatus #9563

Merged
merged 7 commits into from
Dec 21, 2023

Conversation

rainersigwald
Copy link
Member

@rainersigwald rainersigwald commented Dec 19, 2023

Fixes #9562 by triggering a full-line redraw when the length of the duration string increases.

long-running.duration.pushes.left.mp4

@ghost
Copy link

ghost commented Dec 19, 2023

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

@rainersigwald rainersigwald requested a review from a team as a code owner December 19, 2023 20:26
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.vsts-dotnet-ci.yml Show resolved Hide resolved
src/MSBuild/TerminalLogger/SystemStopwatch.cs Show resolved Hide resolved
src/MSBuild/TerminalLogger/NodesFrame.cs Outdated Show resolved Hide resolved
Co-authored-by: Ladi Prosek <ladi.prosek@gmail.com>
@AR-May AR-May merged commit a1ad6b8 into dotnet:vs17.9 Dec 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants