Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETSDKE2E]With NET 9 alpha SDK installed, the message that you are using a preview version of .NET should be displayed when building project in CLI. #9602

Closed
vdanche opened this issue Jan 4, 2024 · 6 comments · Fixed by #9610
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. bug needs-triage Have yet to determine what bucket this goes in.

Comments

@vdanche
Copy link
Member

vdanche commented Jan 4, 2024

Affect build:
.NET 9.0.100-alpha.1.24053.14(runtime-9.0.0-alpha.1.24053.1) from dotnet/installer: .NET SDK Installer (github.com)
Affected Product Language:

Steps to reproduce:

  1. in CLI, dotnet new console and then dotnet build
  2. Check the message displaying in CLI.

Expected Result:
the message that you are using a preview version of .NET should be displayed.
Actual Result:
the message that you are using a preview version of .NET has been removed.
image

But in VS(17.9 perview 3 + 9.0.100-alpha.1.24053.14 SDK). create a net9.0 console and build in VS, the message that you are using a preview version of .NET is still displayed.
image

dotnet --info ``` .NET SDK: Version: 9.0.100-alpha.1.24053.14 Commit: 48543d2076 Workload version: 9.0.100-manifests.ae1d05f3

Runtime Environment:
OS Name: Windows
OS Version: 10.0.20348
OS Platform: Windows
RID: win-x64
Base Path: C:\Program Files\dotnet\sdk\9.0.100-alpha.1.24053.14\

.NET workloads installed:
[maui-windows]
Installation Source: VS 17.9.34502.94
Manifest Version: 8.0.3/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.maui\8.0.3\WorkloadManifest.json
Install Type: FileBased

[maccatalyst]
Installation Source: VS 17.9.34502.94
Manifest Version: 17.0.8500/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.maccatalyst\17.0.8500\WorkloadManifest.json
Install Type: FileBased

[ios]
Installation Source: VS 17.9.34502.94
Manifest Version: 17.0.8500/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.ios\17.0.8500\WorkloadManifest.json
Install Type: FileBased

[android]
Installation Source: VS 17.9.34502.94
Manifest Version: 34.0.52/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.android\34.0.52\WorkloadManifest.json
Install Type: FileBased

[aspire]
Installation Source: VS 17.9.34502.94
Manifest Version: 8.0.0-preview.1.23557.2/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.aspire\8.0.0-preview.1.23557.2\WorkloadManifest.json
Install Type: FileBased

Host:
Version: 9.0.0-alpha.1.24053.1
Architecture: x64
Commit: cc26196708

.NET SDKs installed:
8.0.200-preview.23620.12 [C:\Program Files\dotnet\sdk]
9.0.100-alpha.1.24053.14 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.25 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 7.0.14 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.0-alpha.1.23620.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.25 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 7.0.14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 9.0.0-alpha.1.24053.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 6.0.25 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 7.0.14 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 9.0.0-alpha.1.24053.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
x86 [C:\Program Files (x86)\dotnet]
registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
Not set

global.json file:
Not found

Learn more:
https://aka.ms/dotnet/info

</details>
@vdanche
Copy link
Member Author

vdanche commented Jan 4, 2024

This problem is also reproduced on Win ARM64/MacOS/Linux

@marcpopMSFT marcpopMSFT added the Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. label Jan 4, 2024
@rainersigwald rainersigwald transferred this issue from dotnet/sdk Jan 4, 2024
@rainersigwald rainersigwald added needs-triage Have yet to determine what bucket this goes in. and removed untriaged labels Jan 4, 2024
@baronfel
Copy link
Member

baronfel commented Jan 4, 2024

This is an expected result of the change in defaults to use Terminal Logger from the CLI. No 'Message' items currently display in Terminal Logger, only Warnings and Errors.

@rainersigwald
Copy link
Member

We have a couple of allowlisted messages (see #9407) and I think we should add this one, too.

@baronfel
Copy link
Member

baronfel commented Jan 4, 2024

Fair point. There's a history of some users (internals and externals) being annoyed by the message when it appears multiple times, though: dotnet/sdk#10352

So if we did do anything custom here it might also be nice to dedupe these specific messages.

@rainersigwald
Copy link
Member

Yeah I'd be totally on board with that . . . except it's harder than the two-liner change I already have :-P

rainersigwald added a commit to rainersigwald/msbuild that referenced this issue Jan 5, 2024
Fixes dotnet#9602 by emitting NETSDK1057 as an immediate message at most once
in the TerminalLogger.

```sh-session
❯ dotnet build
MSBuild version 17.10.0-dev-24055-01+3500455af for .NET
Restore complete (1.1s)
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  Lib1 succeeded (3.1s) → Lib1\bin\Debug\net9.0\Lib1.dll
  Lib2 succeeded (3.1s) → Lib2\bin\Debug\net9.0\Lib2.dll
  App succeeded (3.2s) → App\bin\Debug\net9.0\App.dll

Build succeeded in 4.5s
```
@baronfel baronfel added the bug label Jan 8, 2024
rainersigwald added a commit that referenced this issue Jan 8, 2024
Fixes #9602 by emitting NETSDK1057 as an immediate message at most once
in the TerminalLogger.

```sh-session
❯ dotnet build
MSBuild version 17.10.0-dev-24055-01+3500455af for .NET
Restore complete (1.1s)
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  Lib1 succeeded (3.1s) → Lib1\bin\Debug\net9.0\Lib1.dll
  Lib2 succeeded (3.1s) → Lib2\bin\Debug\net9.0\Lib2.dll
  App succeeded (3.2s) → App\bin\Debug\net9.0\App.dll

Build succeeded in 4.5s
```

Co-authored-by: Ladi Prosek <ladi.prosek@gmail.com>
@vdanche
Copy link
Member Author

vdanche commented Jan 12, 2024

This issue has been fixed on 9.0.100-alpha.1.24060.43(runtime-9.0.0-alpha.1.24060.1), thanks
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. bug needs-triage Have yet to determine what bucket this goes in.
Projects
None yet
4 participants