-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TL: Fix logs appearance from nuget client/credential provider #9407
TL: Fix logs appearance from nuget client/credential provider #9407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a couple more tweaks!
ad73373
to
52e49cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you. From UX perspective I wonder if the output shouldn't contain the name of the project because it looks like we're currently printing just the bare message which is going to land at a random line. It may be mistakenly attributed to the last project that finished building.
cc @baronfel
I see what you mean, but just for illustration: Since it's a part of the Restore target that contains the ProjectName, I am not fully confident we need to include this information in the immediate messages. |
I see, it's always restore-only. In that case, please ignore me! |
Let's wait for @baronfel anyway :) |
I agree with @YuliiaKovalova's finding here 👍 |
Fixes #9068
Context
Before this change we were showing specific messages in TL that matched a selected pattern + all the build warnings were displayed at the final build stage.
Changes Made
Introduce immediate print functionality for blocking messages from nuget client/credential provider
Testing
Manual + UTs
Notes
The implementation will be reconsidered after introducing TL API