Prevent contention between CancelAllSubmissions and EndBuild #10744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable test ProjectItemSpecTooLong * Get full path * Get the rootlength from tempProject * Update the test exception * Update the test description * Update test description * Update WindowsFileSystem.FileExists * revert test description * Adds all assembly redirects to the config file
…: Build ID 10262578 (#10685) * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 10262578 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 10262578
…0688) * Update dependencies from https://github.com/dotnet/roslyn build 20240920.11 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.Net.Compilers.Toolset From Version 4.12.0-3.24463.9 -> To Version 4.12.0-3.24470.11 * Update dependencies from https://github.com/nuget/nuget.client build 6.12.0.112 NuGet.Build.Tasks From Version 6.12.0-rc.106 -> To Version 6.12.0-rc.112 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Part of: #10665 Updating the localization comment so changes do not get merged automatically.
Part of: #10665 Updating branch flow from 17.11 -> 17.12 -> main.
* remove DesignTime restriction * add msbuildruntimetype condition
* Fix setting ProjectMetadataElement.Name * Fix xmldoc
Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com> Co-authored-by: YuliiaKovalova <ykovalova@microsoft.com>
…0730) * Update dependencies from https://github.com/dotnet/roslyn build 20240929.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.Net.Compilers.Toolset From Version 4.12.0-3.24470.11 -> To Version 4.12.0-3.24479.1 * Update dependencies from https://github.com/nuget/nuget.client build 6.12.0.120 NuGet.Build.Tasks From Version 6.12.0-rc.112 -> To Version 6.12.0-rc.120 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…923.1 (#10731) Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24466.2 -> To Version 9.0.0-beta.24473.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Use SequenceEqual in win32 GetFullPath This should be slightly more efficient since it's vectorizable. * fixup! Use SequenceEqual in win32 GetFullPath
The doc comment mentioned that the parameterless constructor existed only for COM but it was still easy to find, causing problems like #10660. Hide it from IDE completion and extend the comment.
* Separated release checklist into sections * Added more check for DARC channel subscriptions * Update documentation/release-checklist.md Co-authored-by: Rainer Sigwald <raines@microsoft.com> --------- Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com> Co-authored-by: Rainer Sigwald <raines@microsoft.com>
JanKrivanek
force-pushed
the
proto/fix-solution-hang
branch
from
8e225d9 to
a7cbaae
Compare
|
superseded by #10745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10709
Context
VS hangs during solution close - turns out to be caused by hang in
BuildManager.EndBuildThere are
almost 3kover 4k (and counting) cases hit in wild on 17.11 (details)It turns out to be a contention between
CancelAllSubmissionsandEndBuild(for the state of_buildManagerState) - more details in the bug: #10709 (comment)Changes Made
CancelAllSubmissionsis allowed to be executed even ifEndBuildwas initiated