RAR as a service - Node startup #5613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donJoseLuis
requested changes
Aug 5, 2020
ref/Microsoft.Build.Tasks.Core/net/Microsoft.Build.Tasks.Core.cs
Outdated
Show resolved
Hide resolved
ref/Microsoft.Build.Tasks.Core/net/Microsoft.Build.Tasks.Core.cs
Outdated
Show resolved
Hide resolved
ref/Microsoft.Build.Tasks.Core/net/Microsoft.Build.Tasks.Core.cs
Outdated
Show resolved
Hide resolved
src/Build/BackEnd/Components/Communications/NodeEndpointOutOfProc.cs
Outdated
Show resolved
Hide resolved
src/Tasks/ResolveAssemblyReferences/Contract/IResolveAssemblyReferenceTaskHandler.cs
Outdated
Show resolved
Hide resolved
Forgind
reviewed
Aug 6, 2020
src/Build/BackEnd/Components/Communications/NodeEndpointOutOfProc.cs
Outdated
Show resolved
Hide resolved
src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcRar.cs
Outdated
Show resolved
Hide resolved
src/Build/BackEnd/Components/SdkResolution/MainNodeSdkResolverService.cs
Outdated
Show resolved
Hide resolved
ladipro
reviewed
Aug 6, 2020
Co-authored-by: Ladi Prosek <ladi.prosek@gmail.com>
…into rarAsService/node
Forgind
reviewed
Aug 7, 2020
ostorc
force-pushed
the
rarAsService/node
branch
from
20e4046 to
268b4d7
Compare
|
/azp run |
|
Pull request contains merge conflicts. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
Forgind
approved these changes
Aug 28, 2020
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
ladipro
reviewed
Aug 31, 2020
Co-authored-by: Ladi Prosek <ladi.prosek@gmail.com>
donJoseLuis
approved these changes
Aug 31, 2020
src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcBase.cs
Show resolved
Hide resolved
ladipro
approved these changes
Sep 1, 2020
Typos Co-authored-by: Ladi Prosek <ladi.prosek@gmail.com>
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Sep 29, 2020
This reverts commit 51a1071, reversing changes made to d58e2b7. This is an overkill solution to dotnet#5752. Since the new functionality isn't working, it's easier to just remove it rather than juggle assembly loading.
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Oct 8, 2020
This reverts commit 51a1071, reversing changes made to d58e2b7. This is an overkill solution to dotnet#5752. Since the new functionality isn't working, it's easier to just remove it rather than juggle assembly loading.
AR-May
added a commit
to AR-May/msbuild
that referenced
this pull request
Jan 27, 2021
…ce/node" (dotnet#5758)" This reverts commit d6ef841.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides MSBuild necessary infrastructure to start up new RAR node and connect to it and perform simple request (just for showcase purpose, will be deleted in next phase).
Still WIP, have to go through the code again and check if there are any possible edge cases. Also I had merged rework of Handshake, so I will have to look into that.
Implements #5555