RAR as a service - Node startup

Directory.Build.props

@@ -51,7 +51,7 @@
         NU5125: Arcade uses licenseUrl when doing pack, which now causes NU5125 warning. This disables that warning until arcade can switch over.
     -->
 
-    <NoWarn>$(NoWarn);NU1603;NU5105;NU5125;1701;1702</NoWarn>
+    <NoWarn>$(NoWarn);NU1603;NU5105;NU5125;1701;1702;VSTHRD002;VSTHRD105;VSTHRD110;VSTHRD200</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)' == 'Debug-MONO'">

eng/Packages.props

@@ -16,7 +16,7 @@
     <PackageReference Update="Microsoft.Net.Compilers.Toolset" Version="$(MicrosoftNetCompilersToolsetVersion)" />
     <PackageReference Update="Microsoft.VisualStudio.SDK.EmbedInteropTypes" Version="15.0.15" />
     <PackageReference Update="Microsoft.VisualStudio.Setup.Configuration.Interop" Version="1.16.30" />
-    <PackageReference Update="Microsoft.Win32.Registry" Version="4.3.0" />
+    <PackageReference Update="Microsoft.Win32.Registry" Version="4.6.0" />
     <PackageReference Update="NuGet.Build.Tasks" Version="$(NuGetBuildTasksVersion)" />
     <PackageReference Update="NuGet.Frameworks" Version="$(NuGetBuildTasksVersion)" />
     <PackageReference Update="PdbGit" Version="3.0.41" />
@@ -48,6 +48,7 @@
     <PackageReference Update="xunit.assert" Version="$(XUnitVersion)" />
     <PackageReference Update="xunit.console" Version="$(XUnitVersion)" />
     <PackageReference Update="xunit.core" Version="$(XUnitVersion)" />
+    <PackageReference Update="StreamJsonRpc" Version="2.4.48" />
   </ItemGroup>
 
   <ItemGroup Condition="'$(DotNetBuildFromSource)' != 'true'">

ref/Microsoft.Build.Tasks.Core/net/Microsoft.Build.Tasks.Core.cs

@@ -940,6 +940,7 @@ public ResolveAssemblyReference() { }
         public string TargetFrameworkVersion { get { throw null; } set { } }
         public string TargetProcessorArchitecture { get { throw null; } set { } }
         public bool UnresolveFrameworkAssembliesFromHigherFrameworks { get { throw null; } set { } }
+        public bool UseResolveAssemblyReferenceService { get { throw null; } set { } }
         public string WarnOrErrorOnTargetArchitectureMismatch { get { throw null; } set { } }
         public override bool Execute() { throw null; }
     }
@@ -2543,6 +2544,21 @@ public partial interface IVbcHostObjectFreeThreaded
         bool Compile();
     }
 }
+namespace Microsoft.Build.Tasks.ResolveAssemblyReferences.Contract
+{
+    public partial interface IResolveAssemblyReferenceTaskHandler : System.IDisposable
+    {
+        System.Threading.Tasks.Task<int> GetNumber(int parameter);
+    }
+}
+namespace Microsoft.Build.Tasks.ResolveAssemblyReferences.Server
+{
+    public sealed partial class RarController
+    {
+        public RarController(string pipeName) { }
+        public System.Threading.Tasks.Task<int> StartAsync(System.Threading.CancellationToken cancellationToken=default(System.Threading.CancellationToken)) { throw null; }
+    }
+}
 namespace Microsoft.Build.Tasks.Xaml
 {
     public partial class CommandLineArgumentRelation : Microsoft.Build.Tasks.Xaml.PropertyRelation

ref/Microsoft.Build.Tasks.Core/netstandard/Microsoft.Build.Tasks.Core.cs

@@ -598,6 +598,7 @@ public ResolveAssemblyReference() { }
         public string TargetFrameworkVersion { get { throw null; } set { } }
         public string TargetProcessorArchitecture { get { throw null; } set { } }
         public bool UnresolveFrameworkAssembliesFromHigherFrameworks { get { throw null; } set { } }
+        public bool UseResolveAssemblyReferenceService { get { throw null; } set { } }
         public string WarnOrErrorOnTargetArchitectureMismatch { get { throw null; } set { } }
         public override bool Execute() { throw null; }
     }
@@ -1045,3 +1046,18 @@ public partial interface IVbcHostObjectFreeThreaded
         bool Compile();
     }
 }
+namespace Microsoft.Build.Tasks.ResolveAssemblyReferences.Contract
+{
+    public partial interface IResolveAssemblyReferenceTaskHandler : System.IDisposable
+    {
+        System.Threading.Tasks.Task<int> GetNumber(int parameter);
+    }
+}
+namespace Microsoft.Build.Tasks.ResolveAssemblyReferences.Server
+{
+    public sealed partial class RarController
+    {
+        public RarController(string pipeName) { }
+        public System.Threading.Tasks.Task<int> StartAsync(System.Threading.CancellationToken cancellationToken=default(System.Threading.CancellationToken)) { throw null; }
+    }
+}

ref/Microsoft.Build/net/Microsoft.Build.cs

@@ -1096,6 +1096,7 @@ public enum NodeAffinity
         Any = 2,
         InProc = 0,
         OutOfProc = 1,
+        RarNode = 3,
     }
     public enum NodeEngineShutdownReason
     {
@@ -1107,6 +1108,7 @@ public enum NodeEngineShutdownReason
     public partial class OutOfProcNode
     {
         public OutOfProcNode() { }
+        public Microsoft.Build.Execution.NodeEngineShutdownReason Run(bool enableReuse, bool lowPriority, bool workerNode, out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
         public Microsoft.Build.Execution.NodeEngineShutdownReason Run(bool enableReuse, bool lowPriority, out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
         public Microsoft.Build.Execution.NodeEngineShutdownReason Run(bool enableReuse, out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
         public Microsoft.Build.Execution.NodeEngineShutdownReason Run(out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
@@ -1382,6 +1384,12 @@ internal ProjectTaskOutputPropertyInstance() { }
         public string TaskParameter { get { throw null; } }
         public override Microsoft.Build.Construction.ElementLocation TaskParameterLocation { get { throw null; } }
     }
+    public sealed partial class RarNode
+    {
+        public RarNode() { }
+        public Microsoft.Build.Execution.NodeEngineShutdownReason Run(bool nodeReuse, bool lowPriority, out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
+        public Microsoft.Build.Execution.NodeEngineShutdownReason Run(out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
+    }
     public partial class RequestedProjectState
     {
         public RequestedProjectState() { }

ref/Microsoft.Build/netstandard/Microsoft.Build.cs

@@ -1090,6 +1090,7 @@ public enum NodeAffinity
         Any = 2,
         InProc = 0,
         OutOfProc = 1,
+        RarNode = 3,
     }
     public enum NodeEngineShutdownReason
     {
@@ -1101,6 +1102,7 @@ public enum NodeEngineShutdownReason
     public partial class OutOfProcNode
     {
         public OutOfProcNode() { }
+        public Microsoft.Build.Execution.NodeEngineShutdownReason Run(bool enableReuse, bool lowPriority, bool workerNode, out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
         public Microsoft.Build.Execution.NodeEngineShutdownReason Run(bool enableReuse, bool lowPriority, out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
         public Microsoft.Build.Execution.NodeEngineShutdownReason Run(bool enableReuse, out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
         public Microsoft.Build.Execution.NodeEngineShutdownReason Run(out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
@@ -1376,6 +1378,12 @@ internal ProjectTaskOutputPropertyInstance() { }
         public string TaskParameter { get { throw null; } }
         public override Microsoft.Build.Construction.ElementLocation TaskParameterLocation { get { throw null; } }
     }
+    public sealed partial class RarNode
+    {
+        public RarNode() { }
+        public Microsoft.Build.Execution.NodeEngineShutdownReason Run(bool nodeReuse, bool lowPriority, out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
+        public Microsoft.Build.Execution.NodeEngineShutdownReason Run(out System.Exception shutdownException) { shutdownException = default(System.Exception); throw null; }
+    }
     public partial class RequestedProjectState
     {
         public RequestedProjectState() { }

src/Build/BackEnd/Components/BuildComponentFactoryCollection.cs

@@ -61,6 +61,7 @@ public void RegisterDefaultFactories()
 
             _componentEntriesByType[BuildComponentType.InProcNodeProvider] = new BuildComponentEntry(BuildComponentType.InProcNodeProvider, NodeProviderInProc.CreateComponent, CreationPattern.Singleton);
             _componentEntriesByType[BuildComponentType.OutOfProcNodeProvider] = new BuildComponentEntry(BuildComponentType.OutOfProcNodeProvider, NodeProviderOutOfProc.CreateComponent, CreationPattern.Singleton);
+            _componentEntriesByType[BuildComponentType.OutOfProcNodeRarProvider] = new BuildComponentEntry(BuildComponentType.OutOfProcNodeRarProvider, NodeProviderOutOfProcRar.CreateComponent, CreationPattern.Singleton);
             _componentEntriesByType[BuildComponentType.OutOfProcTaskHostNodeProvider] = new BuildComponentEntry(BuildComponentType.OutOfProcTaskHostNodeProvider, NodeProviderOutOfProcTaskHost.CreateComponent, CreationPattern.Singleton);
 
             // PropertyCache,

src/Build/BackEnd/Components/Communications/INodeProvider.cs

@@ -24,7 +24,12 @@ internal enum NodeProviderType
         /// <summary>
         /// The provider provides remote nodes.
         /// </summary>
-        Remote
+        Remote,
+
+        /// <summary>
+        /// The provider provides RAR nodes.
+        /// </summary>
+        ResolveAssemblyReference
     }
 
     /// <summary>

src/Build/BackEnd/Components/Communications/NodeEndpointOutOfProc.cs

@@ -22,6 +22,8 @@ internal class NodeEndpointOutOfProc : NodeEndpointOutOfProcBase
 
         private readonly bool _lowPriority;
 
+        private readonly bool _workerNode;
+
         #endregion
 
         #region Constructors and Factories
@@ -33,16 +35,20 @@ internal class NodeEndpointOutOfProc : NodeEndpointOutOfProcBase
         /// <param name="host">The component host.</param>
         /// <param name="enableReuse">Whether this node may be reused for a later build.</param>
         /// <param name="lowPriority">Whether this node is low priority.</param>
+        /// <param name="workerNode">Indicates if node is worker node (can accept normal MSBuild work)</param>
         internal NodeEndpointOutOfProc(
             string pipeName, 
             IBuildComponentHost host,
             bool enableReuse,
-            bool lowPriority)
+            bool lowPriority,
+            bool workerNode)
         {
             ErrorUtilities.VerifyThrowArgumentNull(host, "host");
             _componentHost = host;
             _enableReuse = enableReuse;
             _lowPriority = lowPriority;
+            _workerNode = workerNode;
+
 
             InternalConstruct(pipeName);
         }
@@ -54,7 +60,12 @@ internal NodeEndpointOutOfProc(
         /// </summary>
         protected override Handshake GetHandshake()
         {
-            return new Handshake(CommunicationsUtilities.GetHandshakeOptions(taskHost: false, is64Bit: EnvironmentUtilities.Is64BitProcess, nodeReuse: _enableReuse, lowPriority: _lowPriority));
+            return new Handshake(CommunicationsUtilities.GetHandshakeOptions(
+                taskHost: false,
+                is64Bit: EnvironmentUtilities.Is64BitProcess,
+                nodeReuse: _enableReuse,
+                lowPriority: _lowPriority,
+                _workerNode));
         }
 
         #region Structs

src/Build/BackEnd/Components/Communications/NodeManager.cs

@@ -35,6 +35,12 @@ internal class NodeManager : INodeManager
         /// </summary> 
         private INodeProvider _outOfProcNodeProvider;
 
+
+        /// <summary>
+        /// The node provider for out-of-proc RAR nodes.
+        /// </summary> 
+        private INodeProvider _outOfProcRarNodeProvider;
+
         /// <summary>
         /// The build component host.
         /// </summary>
@@ -113,6 +119,11 @@ public NodeInfo CreateNode(NodeConfiguration configuration, NodeAffinity nodeAff
                 nodeId = AttemptCreateNode(_outOfProcNodeProvider, configuration);
             }
 
+            if (nodeId == InvalidNodeId && nodeAffinity == NodeAffinity.RarNode)
+            {
+                nodeId = AttemptCreateNode(_outOfProcRarNodeProvider, configuration);
+            }
+
             if (nodeId == InvalidNodeId)
             {
                 return null;
@@ -166,6 +177,8 @@ public void ShutdownConnectedNodes(bool enableReuse)
             {
                 _outOfProcNodeProvider.ShutdownConnectedNodes(enableReuse);
             }
+
+            _outOfProcRarNodeProvider?.ShutdownConnectedNodes(enableReuse);
         }
 
         /// <summary>
@@ -178,6 +191,8 @@ public void ShutdownAllNodes()
             {
                 _outOfProcNodeProvider.ShutdownAllNodes();
             }
+
+            _outOfProcRarNodeProvider?.ShutdownAllNodes();
         }
 
         #endregion
@@ -196,6 +211,7 @@ public void InitializeComponent(IBuildComponentHost host)
 
             _inProcNodeProvider = _componentHost.GetComponent(BuildComponentType.InProcNodeProvider) as INodeProvider;
             _outOfProcNodeProvider = _componentHost.GetComponent(BuildComponentType.OutOfProcNodeProvider) as INodeProvider;
+            _outOfProcRarNodeProvider = _componentHost.GetComponent(BuildComponentType.OutOfProcNodeRarProvider) as INodeProvider;
 
             _componentShutdown = false;
 
@@ -217,8 +233,14 @@ public void ShutdownComponent()
                 ((IDisposable)_outOfProcNodeProvider).Dispose();
             }
 
+            if (_outOfProcRarNodeProvider is IDisposable rarNodeProvider)
+            {
+                rarNodeProvider.Dispose();
+            }
+
             _inProcNodeProvider = null;
             _outOfProcNodeProvider = null;
+            _outOfProcRarNodeProvider = null;
             _componentHost = null;
             _componentShutdown = true;
 

src/Build/BackEnd/Components/Communications/NodeProviderOutOfProc.cs

@@ -63,10 +63,11 @@ public int AvailableNodes
         /// </summary>
         /// <param name="enableNodeReuse">Is reuse of build nodes allowed?</param>
         /// <param name="enableLowPriority">Is the build running at low priority?</param>
-        internal static Handshake GetHandshake(bool enableNodeReuse, bool enableLowPriority)
+        /// <param name="workerNode">/Indicates if node can accept standard MSBuild work</param>
+        internal static Handshake GetHandshake(bool enableNodeReuse, bool enableLowPriority, bool workerNode)
         {
             CommunicationsUtilities.Trace("MSBUILDNODEHANDSHAKESALT=\"{0}\", msbuildDirectory=\"{1}\", enableNodeReuse={2}, enableLowPriority={3}", Traits.MSBuildNodeHandshakeSalt, BuildEnvironmentHelper.Instance.MSBuildToolsDirectory32, enableNodeReuse, enableLowPriority);
-            return new Handshake(CommunicationsUtilities.GetHandshakeOptions(taskHost: false, nodeReuse: enableNodeReuse, lowPriority: enableLowPriority, is64Bit: EnvironmentUtilities.Is64BitProcess));
+            return new Handshake(CommunicationsUtilities.GetHandshakeOptions(taskHost: false, nodeReuse: enableNodeReuse, lowPriority: enableLowPriority, workerNode: workerNode, is64Bit: EnvironmentUtilities.Is64BitProcess));
         }
 
         /// <summary>

src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcBase.cs

@@ -11,6 +11,7 @@
 using System.Threading.Tasks;
 using System.Runtime.InteropServices;
 using System.Security.Principal;
+using Task = System.Threading.Tasks.Task;
 
 using Microsoft.Build.Eventing;
 using Microsoft.Build.Exceptions;
@@ -124,13 +125,16 @@ protected void ShutdownAllNodes(bool nodeReuse, NodeContextTerminateDelegate ter
                 int timeout = 30;
 
                 // Attempt to connect to the process with the handshake without low priority.
-                Stream nodeStream = TryConnectToProcess(nodeProcess.Id, timeout, NodeProviderOutOfProc.GetHandshake(nodeReuse, false));
+                Stream nodeStream = TryConnectToProcess(nodeProcess.Id, timeout, NodeProviderOutOfProc.GetHandshake(nodeReuse, false, true));
 
-                if (null == nodeStream)
-                {
-                    // If we couldn't connect attempt to connect to the process with the handshake including low priority.
-                    nodeStream = TryConnectToProcess(nodeProcess.Id, timeout, NodeProviderOutOfProc.GetHandshake(nodeReuse, true));
-                }
+                // If we couldn't connect attempt to connect to the process with the handshake including low priority.
+                nodeStream ??= TryConnectToProcess(nodeProcess.Id, timeout, NodeProviderOutOfProc.GetHandshake(nodeReuse, true, true));
+
+                // Attempt to connect to the non-worker process
+                // Attempt to connect to the process with the handshake without low priority.
+                nodeStream ??= TryConnectToProcess(nodeProcess.Id, timeout, NodeProviderOutOfProc.GetHandshake(nodeReuse, false, false));
+                // If we couldn't connect attempt to connect to the process with the handshake including low priority.
+                nodeStream ??= TryConnectToProcess(nodeProcess.Id, timeout, NodeProviderOutOfProc.GetHandshake(nodeReuse, true, false));
 
                 if (null != nodeStream)
                 {
@@ -224,7 +228,7 @@ protected NodeContext GetNode(string msbuildLocation, string commandLineArgs, in
                 string taskHostNameForClr2TaskHost = Path.GetFileNameWithoutExtension(NodeProviderOutOfProcTaskHost.TaskHostNameForClr2TaskHost);
                 if (Path.GetFileNameWithoutExtension(msbuildLocation).Equals(taskHostNameForClr2TaskHost, StringComparison.OrdinalIgnoreCase))
                 {
-                    if (FrameworkLocationHelper.GetPathToDotNetFrameworkV35(DotNetFrameworkArchitecture.Current) == null)
+                    if (FrameworkLocationHelper.GetPathToDotNetFrameworkV35(Shared.DotNetFrameworkArchitecture.Current) == null)
                     {
                         CommunicationsUtilities.Trace
                             (