Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended the section about extending builds #9012

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

assarbad
Copy link
Contributor

Fixes # (not applicable)

Context

Documentation change only.

Changes Made

  • I extended the section about extending the builds a bit
  • Also moved it to the bottom, because it is now the largest section

@assarbad
Copy link
Contributor Author

@dotnet-policy-service agree

@assarbad
Copy link
Contributor Author

Don't quite understand the build failures. This change only affects documentation.

Any ideas, @rainersigwald ?

@AR-May AR-May requested a review from rainersigwald July 18, 2023 13:41
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution - overall looks good to me.

I left couple comments for consideration. The one I'd want to be addressed is the Note bene abberavition - it might not be clear to some readers.

documentation/wiki/MSBuild-Tips-&-Tricks.md Outdated Show resolved Hide resolved
documentation/wiki/MSBuild-Tips-&-Tricks.md Outdated Show resolved Hide resolved
documentation/wiki/MSBuild-Tips-&-Tricks.md Outdated Show resolved Hide resolved
@JanKrivanek
Copy link
Member

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 9012 in repo dotnet/msbuild

@JanKrivanek
Copy link
Member

Seems like we're hitting a wingetbot issue - microsoft/winget-pkgs#111634
Trying to close and reopen to rekick the pipeline

@JanKrivanek JanKrivanek reopened this Jul 27, 2023
@JanKrivanek
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

- Also moved it to the bottom, because it is now the largest section
@assarbad assarbad force-pushed the addition-to-tips-and-tricks branch from a811528 to 4bf1f04 Compare July 28, 2023 21:36
@assarbad
Copy link
Contributor Author

@JanKrivanek updated, hope this resolves it. Have a nice weekend!

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @assarbad for the contribution and the adjustments.

We have a policy of 2 reviewers per PR - so bear with us for a bit.

@JanKrivanek JanKrivanek merged commit 8da5fc7 into dotnet:main Nov 14, 2023
@assarbad assarbad deleted the addition-to-tips-and-tricks branch November 15, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants