Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PR validation have some issue. #111634

Closed
BrandonWanHuanSheng opened this issue Jul 7, 2023 · 23 comments
Closed

The PR validation have some issue. #111634

BrandonWanHuanSheng opened this issue Jul 7, 2023 · 23 comments
Labels
Area-Bots These issues are related to the bots assisting with automation Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@BrandonWanHuanSheng
Copy link
Contributor

BrandonWanHuanSheng commented Jul 7, 2023

          No commit pushedDate could be found for PR 111553 in repo microsoft/winget-pkgs

Originally posted by azure-pipelines[bot] in #111553 (comment)

Actual Behaviour

It look like almost everyone pipelines have this error also. Before, I did not see this issue on before winget pipelines update. ⚠️ Sometimes the pull request does not have label, please be aware because it throws this error out when wingetbot trying to run validation-pipelines. Also, sometimes could be this comment happening on moderator or admin in the repo try to run validation pipelines.

Expected Behaviour

This comments suppose to be gone. Suppose when the pull request add a label and wingetbot will automatically commented 1 time to run the pipelines. Close and Reopened pull request will work as expected.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jul 7, 2023
@BrandonWanHuanSheng BrandonWanHuanSheng changed the title The validation have some issue after adding the waiver label. The PR validation have some issue after adding the waiver label. Jul 7, 2023
@BrandonWanHuanSheng
Copy link
Contributor Author

Screenshot (255)

@BrandonWanHuanSheng BrandonWanHuanSheng changed the title The PR validation have some issue after adding the waiver label. The PR validation have some issue after adding the waiver label with packagedependencies Jul 8, 2023
@stephengillie stephengillie added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Bots These issues are related to the bots assisting with automation and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Jul 8, 2023
@BrandonWanHuanSheng BrandonWanHuanSheng changed the title The PR validation have some issue after adding the waiver label with packagedependencies The PR validation have some issue after adding the waiver label with Package Dependencies Jul 8, 2023
@BrandonWanHuanSheng BrandonWanHuanSheng changed the title The PR validation have some issue after adding the waiver label with Package Dependencies The PR validation have some issue after adding the waiver label Jul 8, 2023
@BrandonWanHuanSheng
Copy link
Contributor Author

@denelon

@krystofkrticka
Copy link
Contributor

This issue also happens even without adding waiver, something is really messed up with the validation pipeline. As you can see in #111653

@BrandonWanHuanSheng BrandonWanHuanSheng changed the title The PR validation have some issue after adding the waiver label The PR validation have some issue. Jul 8, 2023
@BrandonWanHuanSheng
Copy link
Contributor Author

BrandonWanHuanSheng commented Jul 8, 2023

Example: #111666
#111661

@Trenly
Copy link
Contributor

Trenly commented Jul 8, 2023

[Policy] Area-Validation-Pipeline

@microsoft-github-policy-service microsoft-github-policy-service bot added the Area-Validation-Pipeline Issues related to the manifest validation pipeline. label Jul 8, 2023
@BrandonWanHuanSheng
Copy link
Contributor Author

BrandonWanHuanSheng commented Jul 9, 2023

Thank you, Trenly for adding the issue label.

@BrandonWanHuanSheng
Copy link
Contributor Author

#111708

@krystofkrticka
Copy link
Contributor

#111756

@denelon
Copy link
Contributor

denelon commented Jul 11, 2023

We've been looking into this issue. Unfortunately, it seems to currently be in the state where we need to simply retry the pipeline. We will see if we can get into a root cause, but if this is a transient issue with the infrastructure, we may not find a root cause if it subsides.

@CoolPlayLin
Copy link
Contributor

@Alexey-Rivkin
Copy link

Unable to use comment triggers lately.
/azp run perf results in error:
"No commit pushedDate could be found for PR 9238 in repo openucx/ucx"
openucx/ucx#9238 (comment)

@CoolPlayLin
Copy link
Contributor

#113437

@stephengillie
Copy link
Collaborator

stephengillie commented Aug 1, 2023

This package was handled in an especially bad way, removing Validation-Complete and Moderator-Approved labels after manual validation.

@stephengillie
Copy link
Collaborator

This PR was ping-pong'ing between adding and removing Validation-Completed and enabling and disabling automatic squash-and-merge.

@stephengillie
Copy link
Collaborator

stephengillie commented Aug 5, 2023

@mdanish-kh
Copy link
Contributor

This PR won't even run:

PR has 0 files changed, probably that's why

@BrandonWanHuanSheng
Copy link
Contributor Author

BrandonWanHuanSheng commented Aug 9, 2023

How long this issue will closed and resolved?

@stephengillie
Copy link
Collaborator

This PR took 5 minutes to start running:

@BrandonWanHuanSheng
Copy link
Contributor Author

This PR took 5 minutes to start running:

Sometimes the pipelines took long time to start up because pushedDate is synchronizing.

@BrandonWanHuanSheng
Copy link
Contributor Author

BrandonWanHuanSheng commented Aug 13, 2023

Azure Pipelines with issues ended with 1/08/23 16:59.. There is no more about No commit about pushedDate could be found for PR #XXXXXX in repo: microsoft/winget-pkgs. This issue will schedule to close soon.

@BrandonWanHuanSheng
Copy link
Contributor Author

BrandonWanHuanSheng commented Aug 19, 2023

So, while I was watching the repository, because another is filtering my email on the pull request. I also noticed when they stop.

@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Bots These issues are related to the bots assisting with automation Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

9 participants