Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim.nightly: fix url and hash for x86 Arch #111904

Closed
wants to merge 1 commit into from

Conversation

chrisbra
Copy link
Contributor

@chrisbra chrisbra commented Jul 12, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>? manually verified
  • Have you tested your manifest locally with winget install --manifest <path>? (no, not installed)
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


So #111716 again created PR with wrong x86 link and shasum (vedantmgoyal9/winget-releaser#173).

Fix this for the latest upload for vim.vim.nightly.

Microsoft Reviewers: codeflow:open?pullrequest=#111904

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 111904 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 111904 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 12, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) July 12, 2023 08:15
@microsoft-github-policy-service
Copy link
Contributor

chrisbra,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@wingetbot wingetbot added the Validation-Merge-Conflict Package could not be tested due to merge conflict. label Jul 12, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @chrisbra,

The PR could not be validated because there is a merge conflict which adds bad characters to the manifest. Please address the merge conflict and resubmit.

Template: msftbot/mergeConflict

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 12, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 12, 2023
auto-merge was automatically disabled July 12, 2023 12:13

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 111904 in repo microsoft/winget-pkgs

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Validation-Merge-Conflict Package could not be tested due to merge conflict. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 12, 2023
@chrisbra
Copy link
Contributor Author

fixed.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jul 12, 2023
@BrandonWanHuanSheng
Copy link
Contributor

#111634

@chrisbra
Copy link
Contributor Author

unrelated to the issue that this PR is going to fix

@russellbanks
Copy link
Contributor

Sorry for missing this PR @chrisbra. This fix was merged in #111933.

@russellbanks
Copy link
Contributor

Close with reason: Resolved by #111933;

@chrisbra
Copy link
Contributor Author

thanks once more ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants