adjust XmlReader.Create to passed path with potentially invalid character #9028
Conversation
…cter (dotnet#9028) Fixes dotnet#8972 Context dotnet#8931 fixed one instance of the issue with build issues caused by localized characters in OS paths. This PR attempts to address the rest of the same unintended string -> uri conversion Changes Made Passing Stream to XmlReader.Create instead of path in order to prevent unintended string -> uri conversion Testing N/A
|
/backport to vs17.7 |
|
Started backporting to vs17.7: https://github.com/dotnet/msbuild/actions/runs/5657870847 |
|
@rainersigwald an error occurred while backporting to vs17.7, please check the run log for details! Error: @rainersigwald is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=rainersigwald |
|
/backport to vs17.7 |
|
Started backporting to vs17.7: https://github.com/dotnet/msbuild/actions/runs/5657914190 |
There was a problem hiding this comment.
LGTM; @karelz @MihaZupan here's a place where folks are working around URI's escaping of these characters.
We've already discussed this use-case with @karelz when working on #8931 |
These overloads create a URI from the string and can cause problems with GB18030 certification, because that URI gets normalized in a way that doesn't work with all characters. We should instead pass a stream created from the file, as in dotnet#8931 and dotnet#9028. Formalize that rule for the whole repo.
* Ban XmlReader overloads that take string These overloads create a URI from the string and can cause problems with GB18030 certification, because that URI gets normalized in a way that doesn't work with all characters. We should instead pass a stream created from the file, as in #8931 and #9028. Formalize that rule for the whole repo. * Add XPathDocument string ctors to banned symbols * fix 2 more cases for XmlReader.Create call * Update src/Tasks/XamlTaskFactory/RelationsParser.cs Co-authored-by: Jan Krivanek <jankrivanek@microsoft.com> * fix review comments * Update src/Tasks/XamlTaskFactory/RelationsParser.cs Co-authored-by: Rainer Sigwald <raines@microsoft.com> --------- Co-authored-by: Jan Krivanek <jankrivanek@microsoft.com> Co-authored-by: YuliiaKovalova <ykovalova@microsoft.com> Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>
Fixes #8972
Context
#8931 fixed one instance of the issue with build issues caused by localized characters in OS paths.
This PR attempts to address the rest of the same unintended string -> uri conversion
Changes Made
Passing Stream to XmlReader.Create instead of path in order to prevent unintended string -> uri conversion
Testing
N/A