Ban XmlReader overloads that take string #9076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These overloads create a URI from the string and can cause problems with GB18030 certification, because that URI gets normalized in a way that doesn't work with all characters. We should instead pass a stream created from the file, as in dotnet#8931 and dotnet#9028. Formalize that rule for the whole repo.
JanKrivanek
requested changes
Jul 27, 2023
Co-authored-by: Jan Krivanek <jankrivanek@microsoft.com>
rainersigwald
commented
Jul 27, 2023
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
YuliiaKovalova
approved these changes
Aug 1, 2023
rainersigwald
commented
Aug 1, 2023
...but I can ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These overloads create a URI from the string and can cause problems with
GB18030 certification, because that URI gets normalized in a way that
doesn't work with all characters. We should instead pass a stream
created from the file, as in #8931 and #9028.
Formalize that rule for the whole repo.