-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Test target #9193
Adds Test target #9193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok.
Before merging it just needs explicit approval from 1ES and sdk team about the overal msbuild /test
idea and its implementation.
Is there some ETA for this one? |
Update target name, as requested by Test team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nit LGTM
Closing to wake-up stuck auto-merge |
This was added in dotnet#9193 but not usable in VS.
This was added in dotnet#9193 but not usable in VS.
This was added in #9193 but not usable in VS.
Context
At the moment we can run tests with
dotnet /test
, but the same is not true for MSBuild directly. In order to allow for such functionality, a new target is needed.Since it is possible that there exist targets with the name "Test" in the wild, this target is behind a condition, to avoid breaking users who have not opted-in.
usage:
msbuild /t:Test /p:UseMSBuildTestInfrastructure=true
Changes Made
Test