Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Test target #9193

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Adds Test target #9193

merged 8 commits into from
Nov 28, 2023

Conversation

novacole
Copy link
Contributor

@novacole novacole commented Aug 30, 2023

Context

At the moment we can run tests with dotnet /test, but the same is not true for MSBuild directly. In order to allow for such functionality, a new target is needed.

Since it is possible that there exist targets with the name "Test" in the wild, this target is behind a condition, to avoid breaking users who have not opted-in.

usage:
msbuild /t:Test /p:UseMSBuildTestInfrastructure=true

Changes Made

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok.

Before merging it just needs explicit approval from 1ES and sdk team about the overal msbuild /test idea and its implementation.

@MarcoRossignoli
Copy link
Member

Is there some ETA for this one?

Update target name, as requested by Test team
@novacole novacole changed the title Adds MSBuildRunTests target Adds Test target Nov 15, 2023
Copy link
Member

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nit LGTM

@JanKrivanek
Copy link
Member

Closing to wake-up stuck auto-merge

@JanKrivanek JanKrivanek reopened this Nov 27, 2023
@JanKrivanek JanKrivanek merged commit b9d3539 into dotnet:main Nov 28, 2023
8 checks passed
rainersigwald added a commit to rainersigwald/msbuild that referenced this pull request Dec 14, 2023
This was added in dotnet#9193 but not usable in VS.
rainersigwald added a commit to rainersigwald/msbuild that referenced this pull request Dec 15, 2023
This was added in dotnet#9193 but not usable in VS.
rainersigwald added a commit that referenced this pull request Dec 18, 2023
This was added in #9193 but not usable in VS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants