Graph: Mimic quirk for sln-based builds with target name containing semicolon

[dfederm]

Fixes #9376

There is a quirk for solution builds for targets containing semicolons. For example if you do a solution build using /t:"Clean;Build", the metaproject ends up calling the <MSBuild> task using that value, which ends up splitting it into two targes: "Clean" and "Build". However if you try the same thing on a project, it will actually end up attempting to call a target named "Clean;Build", which would also certainly fail in practice (although in theory there could be a distinct target with that crazy name).

This change just mimics that quirk for graph builds.

See linked issue for a practical repro and test cases.

[JanKrivanek]

Looks good.

I have a minor comment for shortening the code

[JanKrivanek]

Why recreating the list twice? (SplitSemiColonSeparatedList already creates new)

Suggested change

	{
	List<string> newEntryTargets = new(entryProjectTargets.Count);
	foreach (string entryTarget in entryProjectTargets)
	{
	foreach (string s in ExpressionShredder.SplitSemiColonSeparatedList(entryTarget))
	{
	newEntryTargets.Add(s);
	}
	}
	entryProjectTargets = newEntryTargets;
	}
	{
	entryProjectTargets = entryProjectTargets
	.SelectMany(target => ExpressionShredder.SplitSemiColonSeparatedList(target))
	.ToList();
	}

[yuehuang010]

FYI, long long time ago, I added a funky feature to address solution building multiple targets, non-graph. Looks up SolutionProjectReferenceAllTargets or SlnProjectResolveProjectReference. I wasn't able to enable it because there was a high chance of a regression due to missing P2P references with a different build order. With graph build, this turns over a new leaf so perhaps consider addressing the issue directly.

[JanKrivanek]

FYI, long long time ago, I added a funky feature to address solution building multiple targets, non-graph. Looks up SolutionProjectReferenceAllTargets or SlnProjectResolveProjectReference. I wasn't able to enable it because there was a high chance of a regression due to missing P2P references with a different build order. With graph build, this turns over a new leaf so perhaps consider addressing the issue directly.

@yuehuang010 - this one?: #7512

[AR-May]

Team triage: It seems to be resolved via PR #9452. We decided to close this one in favor to #9452.