Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always unquote target parameters #9452

Merged

Conversation

f-alizada
Copy link
Contributor

Fixes #9442

Context

Currently if target parameter provided with the quoted value: /t:"Clean;Build" from cmd it will be parsed as "Clean;Build"
Which results not finding the provided target, unless there is existing such target with name "Clean;Build". However it is not the case for powershell.

Changes Made

Unquote target switch parameters before prasing.
The functionality is under the change wave.

Testing

Added UnitTesting, all existing tests should pass as well, without breaking it.

Farhad Alizada added 3 commits November 24, 2023 10:48
documentation/wiki/ChangeWaves.md Outdated Show resolved Hide resolved
src/MSBuild/CommandLineSwitches.cs Show resolved Hide resolved
src/Framework/Traits.cs Outdated Show resolved Hide resolved
src/MSBuild/CommandLineSwitches.cs Outdated Show resolved Hide resolved
src/MSBuild/CommandLineSwitches.cs Outdated Show resolved Hide resolved
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@f-alizada
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@baronfel
Copy link
Member

baronfel commented Dec 1, 2023

We should consider -p separately - I know this has been a big pain in the SDK parsing/forwarding and it would be nice to rationalize it all.

@f-alizada f-alizada merged commit f5ae5c6 into dotnet:main Dec 4, 2023
8 checks passed
@f-alizada f-alizada deleted the dev/f-alizada/enclosed-target-list-fix branch June 14, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Enclosed target list works differently in PWS and CDM
6 participants