Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MauiBlazor iOS Scenarios #2387

Merged
merged 3 commits into from
Apr 20, 2022
Merged

MauiBlazor iOS Scenarios #2387

merged 3 commits into from
Apr 20, 2022

Conversation

TanayParikh
Copy link
Contributor

iOS version of #2386.

@TanayParikh TanayParikh changed the title MauiBlazorIOS Scenario MauiBlazor iOS & Mac Catalyst Scenarios Apr 20, 2022
@TanayParikh
Copy link
Contributor Author

@LoopedBard3 @DrewScoggins requesting review / merge please. (don't have perms to request GitHub review directly 😄)

@TanayParikh
Copy link
Contributor Author

Is the mauimaccatalyst scenario required?

Looks like the iOS scenario is being utilized for MacCatalyst as well:

https://github.com/dotnet/runtime/blob/d5ce000205e1dff7a024035871b55a7a3bd677d8/eng/testing/performance/ios_scenarios.proj#L39

@TanayParikh TanayParikh mentioned this pull request Apr 20, 2022
Merged
@LoopedBard3
Copy link
Member

Ultimately, if you don't copy over the MacCatalyst helix work item there is no need to build for MacCatalyst. It is currently more of a remnant from while we were trying to get the general flow for iOS setup.

@TanayParikh
Revert "MAUI Mac Catalyst"
a1d5401 
This reverts commit 6a25e00.
@TanayParikh
Copy link
Contributor Author

TanayParikh commented Apr 20, 2022 •
edited
Loading

Ultimately, if you don't copy over the MacCatalyst helix work item there is no need to build for MacCatalyst. It is currently more of a remnant from while we were trying to get the general flow for iOS setup.

Thanks for the clarification, reverted 6a25e00

@TanayParikh TanayParikh changed the title MauiBlazor iOS & Mac Catalyst Scenarios MauiBlazor iOS Scenarios Apr 20, 2022
@TanayParikh TanayParikh mentioned this pull request Apr 20, 2022
Closed
LoopedBard3
LoopedBard3 approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoopedBard3 LoopedBard3 merged commit 851dec7 into dotnet:main Apr 20, 2022
@TanayParikh TanayParikh deleted the taparik/mauiblazorIOSScenario branch April 20, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanayParikh @LoopedBard3