-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAUI][Blazor][PERF] Add Android/iOS/MacCatalyst Maui Blazor Perf Collection #68241
Conversation
Tagging subscribers to this area: @hoyosjs Issue DetailsTo be used in conjunction with: dotnet/performance#2386
|
…net/runtime into taparik/mauiBlazorAndroidAPK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this LGTM. @LoopedBard3 we should track this as another location where we are going to want to unify the setup work that happens in yaml with what we do in the pre.py eventually.
@TanayParikh just want to make sure my comment for your question is seen. |
The --fully-drawn-extra-delay will need a time in seconds (whole seconds) after it, although you don't need the arg if the time between first app startup and fully drawn is less than 2 seconds. |
Thanks, added a 6 second delay (89f5745) as local testing shows it takes ~2.913 seconds, and want to account for some additional buffer in case the CI is slower than my local env. |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
[MAUI][Blazor][PERF] Add IPA file usage for iOS/MacCatalyst Maui Blaz…
Merged in iOS & Mac Catalyst changes too simplify validations |
Adapting #66358 / #67165
To be used in conjunction with: dotnet/performance#2386 / dotnet/performance#2387
For: dotnet/maui#2531