Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAUI][Blazor][PERF] Add Android/iOS/MacCatalyst Maui Blazor Perf Collection #68241

Closed
wants to merge 11 commits into from

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Apr 19, 2022

Adapting #66358 / #67165

To be used in conjunction with: dotnet/performance#2386 / dotnet/performance#2387

For: dotnet/maui#2531

@ghost
Copy link

ghost commented Apr 19, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Adapting #66358 / #67165

To be used in conjunction with: dotnet/performance#2386

Author: TanayParikh
Assignees: TanayParikh
Labels:

area-Infrastructure-coreclr

Milestone: -

Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this LGTM. @LoopedBard3 we should track this as another location where we are going to want to unify the setup work that happens in yaml with what we do in the pre.py eventually.

@LoopedBard3
Copy link
Member

@TanayParikh just want to make sure my comment for your question is seen.

@LoopedBard3
Copy link
Member

The --fully-drawn-extra-delay will need a time in seconds (whole seconds) after it, although you don't need the arg if the time between first app startup and fully drawn is less than 2 seconds.

@TanayParikh
Copy link
Contributor Author

The --fully-drawn-extra-delay will need a time in seconds (whole seconds) after it, although you don't need the arg if the time between first app startup and fully drawn is less than 2 seconds.

Thanks, added a 6 second delay (89f5745) as local testing shows it takes ~2.913 seconds, and want to account for some additional buffer in case the CI is slower than my local env.

@TanayParikh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

[MAUI][Blazor][PERF] Add IPA file usage for iOS/MacCatalyst Maui Blaz…
@TanayParikh
Copy link
Contributor Author

Merged in iOS & Mac Catalyst changes too simplify validations

@TanayParikh TanayParikh changed the title [MAUI][Blazor][PERF] Add APK file usage for Android Maui Blazor SOD [MAUI][Blazor][PERF] Add Android/iOS/MacCatalyst Maui Blazor Perf Collection Apr 20, 2022
@TanayParikh
Copy link
Contributor Author

Closing in favor of #68628 & #68685

@TanayParikh TanayParikh deleted the taparik/mauiBlazorAndroidAPK branch April 29, 2022 23:25
@ghost ghost locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants