Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass evaluated AssemblyName during Roslyn workspace construction #7216

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented May 13, 2021

Discussed via email.

Roslyn would benefit from knowing the project's evaluated AssemblyName property. This change provides it.

Microsoft Reviewers: Open in CodeFlow

@drewnoakes drewnoakes added the Feature-Language-Service Populating the Roslyn workspace with references, source files, analyzers, etc label May 13, 2021
@drewnoakes drewnoakes requested a review from davkean May 13, 2021 12:13
@drewnoakes drewnoakes force-pushed the pass-assembly-name-to-roslyn branch from 1cbcc2f to 933784e Compare June 3, 2021 09:23
@drewnoakes drewnoakes marked this pull request as ready for review June 3, 2021 09:25
@drewnoakes drewnoakes requested a review from a team as a code owner June 3, 2021 09:25
@drewnoakes drewnoakes added this to the 17.0 milestone Jun 3, 2021
@drewnoakes drewnoakes force-pushed the pass-assembly-name-to-roslyn branch 2 times, most recently from 8c5abd4 to 8a8a597 Compare June 5, 2021 02:26
@drewnoakes drewnoakes merged commit 512069d into dotnet:main Jun 6, 2021
@drewnoakes drewnoakes deleted the pass-assembly-name-to-roslyn branch June 6, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Language-Service Populating the Roslyn workspace with references, source files, analyzers, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants