Add a parameter to pass through the initial assembly name #53599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
changed the title
jmarolf
approved these changes
May 21, 2021
|
@jmarolf: it shouldn't; right now if we aren't passing this the default assembly name becomes gibberish with a random GUID, which would be even worse for diagnostics! |
ryzngard
approved these changes
May 21, 2021
sharwell
reviewed
May 21, 2021
|
|
||
| /// <inheritdoc cref="CreateProjectContextAsync"/> | ||
| [Obsolete("Use CreateProjectContextAsync instead")] | ||
| IWorkspaceProjectContext CreateProjectContext(string languageName, string projectUniqueName, string projectFilePath, Guid projectGuid, object? hierarchy, string? binOutputPath, string? assemblyName); |
There was a problem hiding this comment.
😕 Adding a method which from day 1 is obsolete?
There was a problem hiding this comment.
So this is "fun": we obsoleted those methods, the project system tried moving to the new methods; that broke, so they rolled back, and we haven't fixed it. @CyrusNajmabadi what's the next step for resolving that?
There was a problem hiding this comment.
There was an RPS regression when we tried using the new free-threaded API. The logs for that regression have no expired, so to understand that regression will require another PS insertion.
drewnoakes
approved these changes
May 24, 2021
Right now we don't get the command line string for options until the full design time build has completed; however the project system can still give us the evaluated string which is likely to be close enough. This allows features that want to get symbol names for source to have a better chance of having something that they can use and look up in caches or in the cloud.
jasonmalinowski
force-pushed
the
add-api-for-adding-assembly-name
branch
from
677c1ad
to
c2388e7
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we don't get the command line string for options until the full design time build has completed; however the project system can still give us the evaluated string which is likely to be close enough. This allows features that want to get symbol names for source to have a better chance of having something that they can use and look up in caches or in the cloud.
This unblocks dotnet/project-system#7216.