Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AdHocWorkspace for generator benchmarks #7982

Open
chsienki opened this issue Dec 2, 2022 · 1 comment
Open

Use AdHocWorkspace for generator benchmarks #7982

chsienki opened this issue Dec 2, 2022 · 1 comment
Labels

Comments

@chsienki
Copy link
Contributor

chsienki commented Dec 2, 2022

    Can we avoid using MSBuildWorkspace for our benchmarks? I'd much rather use an AdhocWorkspace and Jared's assembly references nugets to more precisely control the environment.

Originally posted by @333fred in #7963 (comment)

@danroth27 danroth27 added the area-compiler Umbrella for all compiler issues label Dec 8, 2022
@ghost ghost added the untriaged label Dec 20, 2022
@chsienki
Copy link
Contributor Author

We're now seeing issues in CI with using MSBuildworkspace and so disabled the tests on CI, we need to switch over to AdhocWorkspace and re-enable them.

Note, this isn't as simple as just switching the workspace and using the assembly references, as the Razor source generator expects certain files (such as the generated msbuild editor config) to be present in order to function correctly, so we'll need to ensure that we can create those too.

We could possibly just evaluate the project and extract out the generated config, but we'll need to make sure we have a process for updating the tests from the on-disk project as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants