[main] Update dependencies from dotnet/arcade #8762

dotnet-maestro · 2023-05-25T13:07:44Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: a0cb50dc-7d38-4a32-e166-08db18b91f66
Build: 20230620.3
Date Produced: June 20, 2023 9:04:29 PM UTC
Commit: 06d73ccc1f421af06c2794741a9913f474f66b3d
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.Arcade.Sdk: from 8.0.0-beta.23269.2 to 8.0.0-beta.23320.3
- Microsoft.SourceLink.GitHub: from 8.0.0-beta.23252.2 to 8.0.0-beta.23314.2
- Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23266.1 to 1.0.0-beta.23312.2

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.SourceLink.GitHub: from 8.0.0-beta.23252.2 to 8.0.0-beta.23314.2 (parent: Microsoft.DotNet.Arcade.Sdk)
- Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23266.1 to 1.0.0-beta.23312.2 (parent: Microsoft.DotNet.Arcade.Sdk)

…524.6 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23274.6

ghost

Auto-approving dependency update.

…525.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23275.2 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk

…526.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23276.2 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk

…527.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23277.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk

…529.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23279.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk

…529.4 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23279.4 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk

…530.3 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23280.3 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23279.1 (parent: Microsoft.DotNet.Arcade.Sdk

…531.3 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23281.3 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23279.1 (parent: Microsoft.DotNet.Arcade.Sdk

davidwengier · 2023-06-02T01:44:46Z

/azp run

azure-pipelines · 2023-06-02T01:44:58Z

Azure Pipelines successfully started running 2 pipeline(s).

…602.3 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23302.3 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23279.1 (parent: Microsoft.DotNet.Arcade.Sdk

…607.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23307.2 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23305.1 (parent: Microsoft.DotNet.Arcade.Sdk

…608.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23308.2 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23305.1 (parent: Microsoft.DotNet.Arcade.Sdk

…609.8 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23309.8 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23305.1 (parent: Microsoft.DotNet.Arcade.Sdk

…613.6 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23313.6 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23252.2 -> To Version 8.0.0-beta.23309.3 (parent: Microsoft.DotNet.Arcade.Sdk

…e2-4e1e-81e0-c48d3d238f51

…614.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23314.1 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23252.2 -> To Version 8.0.0-beta.23309.3 (parent: Microsoft.DotNet.Arcade.Sdk

chsienki · 2023-06-15T17:40:21Z

Skipping failing tests, tracked by #7982

333fred · 2023-06-15T20:53:01Z

@dotnet/razor-tooling this is now failing with a build error in the tooling layer, could you please take a look?

jaredpar · 2023-06-16T18:54:01Z

@baronfel

D:\a\_work\1\s\.dotnet\sdk\8.0.100-preview.5.23303.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(254,5): error NETSDK1201: For projects targeting .NET 8.0 and higher, specifying a RuntimeIdentifier will no longer produce a self contained app by default. To continue building self-contained apps, set the SelfContained property to true or use the --self-contained argument. [D:\a\_work\1\s\src\Razor\src\rzls\rzls.csproj::TargetFramework=net7.0]
##[error].dotnet\sdk\8.0.100-preview.5.23303.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(254,5): error NETSDK1201: (NETCORE_ENGINEERING_TELEMETRY=Build) For projects targeting .NET 8.0 and higher, specifying a RuntimeIdentifier will no longer produce a self contained app by default. To continue building self-contained apps, set the SelfContained property to true or use the --self-contained argument.
D:\a\_work\1\s\.dotnet\sdk\8.0.100-preview.5.23303.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(254,5): error NETSDK1201: For projects targeting .NET 8.0 and higher, specifying a RuntimeIdentifier will no longer produce a self contained app by default. To continue building self-contained apps, set the SelfContained property to true or use the --self-contained argument. [D:\a\_work\1\s\src\Razor\src\rzls\rzls.csproj::TargetFramework=net7.0]
##[error].dotnet\sdk\8.0.100-preview.5.23303.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(254,5): error NETSDK1201: (NETCORE_ENGINEERING_TELEMETRY=Build) For projects targeting .NET 8.0 and higher, specifying a RuntimeIdentifier will no longer produce a self contained app by default. To continue building self-contained apps, set the SelfContained property to true or use the --self-contained argument.
  Microsoft.AspNetCore.Razor.Utilities.Shared -> D:\a\_work\1\s\artifacts\bin\Microsoft.AspNetCore.Razor.Utilities.Shared\Release\net7.0\Microsoft.AspNetCore.Razor.Utilities.Shared.dll

Thought this was changed to not have a diagnostic

maryamariyan · 2023-06-16T19:03:42Z

If we can get unblocked with this PR and get latest arcade bits that would fix specific component governance issues that we are tracking to be done by end of June

…616.6 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23316.6 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23252.2 -> To Version 8.0.0-beta.23314.2 (parent: Microsoft.DotNet.Arcade.Sdk

jjonescz · 2023-06-19T09:19:10Z

src/Razor/src/rzls/rzls.csproj

@@ -6,6 +6,7 @@
    <OutputType>Exe</OutputType>
    <Description>Razor is a markup syntax for adding server-side logic to web pages. This package contains a Razor language server.</Description>
    <EnableApiCheck>false</EnableApiCheck>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>


@jaredpar to suppress the warning, you can do this:

Suggested change

<TreatWarningsAsErrors>false</TreatWarningsAsErrors>

<MSBuildWarningsAsMessages>NETSDK1201</MSBuildWarningsAsMessages>

…619.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23319.1 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23252.2 -> To Version 8.0.0-beta.23314.2 (parent: Microsoft.DotNet.Arcade.Sdk

nagilson · 2023-06-19T16:35:22Z

We were able to resolve this friday evening by setting -p:_SelfContainedWasSpecified=true

…619.3 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23319.3 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23252.2 -> To Version 8.0.0-beta.23314.2 (parent: Microsoft.DotNet.Arcade.Sdk

…620.3 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23320.3 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23252.2 -> To Version 8.0.0-beta.23314.2 (parent: Microsoft.DotNet.Arcade.Sdk

…e2-4e1e-81e0-c48d3d238f51

dotnet/sdk#31893

src/Razor/src/rzls/rzls.csproj

Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>

baronfel

these changes are what I needed to build on Ubuntu

src/Razor/src/rzls/rzls.csproj

Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>

jaredpar · 2023-06-22T23:35:33Z

Looks like our remaining failure is the following issue

Microsoft.Management.Infrastructure can't be loaded in latest .NET 8 Preview 5 build PowerShell/PowerShell#19679
Regression in .NET 8.0-preview.5: dependent assembly is not included in TPA list when running fxdependent pwsh build with preview.5 dotnet.exe runtime#86713

jjonescz · 2023-06-23T07:56:00Z

build.cmd

@@ -1,7 +1,7 @@
 @echo off
 setlocal

-set _args=-restore -build /p:TreatWarningsAsErrors=true %*
+set _args=-restore -build /p:_SelfContainedWasSpecified=true %*


Is this change still needed? There don't seem to be any warnings to suppress in the latest CI builds.

I will revert this and the other change you mentioned after merging. This finally went greenand I want to get this in to unblock other items. Those changes dont' really impact the semantics so should be fine to be in for a few hour.s

jjonescz · 2023-06-23T07:56:36Z

src/Razor/src/rzls/rzls.csproj

@@ -6,6 +6,7 @@
    <OutputType>Exe</OutputType>
    <Description>Razor is a markup syntax for adding server-side logic to web pages. This package contains a Razor language server.</Description>
    <EnableApiCheck>false</EnableApiCheck>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>


This addresses some feedback from #8762

Update dependencies from https://github.com/dotnet/arcade build 20230…

8210355

…524.6 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23269.2 -> To Version 8.0.0-beta.23274.6

dotnet-maestro bot requested review from a team as code owners May 25, 2023 13:07

ghost added area-infrastructure type-dependency update 🔼 labels May 25, 2023

ghost approved these changes May 25, 2023

View reviewed changes

333fred mentioned this pull request May 25, 2023

Update Roslyn bits #8764

Merged

dotnet-maestro bot added 7 commits May 26, 2023 13:07

333fred and others added 10 commits June 2, 2023 12:05

Merge branch 'main' into darc-main-0b91fd41-3be2-4e1e-81e0-c48d3d238f51

e46b375

Update Versions.props

33da1be

Merge remote-tracking branch 'origin/main' into darc-main-0b91fd41-3b…

39d43f6

…e2-4e1e-81e0-c48d3d238f51

Skip failing tests. Tracked by #7982

85d70a3

jjonescz reviewed Jun 19, 2023

View reviewed changes

dotnet-maestro bot and others added 8 commits June 20, 2023 13:06

Merge remote-tracking branch 'origin/main' into darc-main-0b91fd41-3b…

3e75def

…e2-4e1e-81e0-c48d3d238f51

Fix version diff

3d699c4

Work around unsupported base image

8d9b60e

dotnet/sdk#31893

another workaround

254b8da

fix queue names

b7928e1

baronfel reviewed Jun 22, 2023

View reviewed changes

src/Razor/src/rzls/rzls.csproj Outdated Show resolved Hide resolved

jaredpar and others added 3 commits June 22, 2023 13:51

fix container

eaa6538

Update src/Razor/src/rzls/rzls.csproj

c337876

Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>

More

f8497e3

baronfel reviewed Jun 22, 2023

View reviewed changes

src/Razor/src/rzls/rzls.csproj Outdated Show resolved Hide resolved

src/Razor/src/rzls/rzls.csproj Outdated Show resolved Hide resolved

Apply suggestions from code review

e9d8dc3

Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>

333fred approved these changes Jun 22, 2023

View reviewed changes

powershell

c49335a

jjonescz reviewed Jun 23, 2023

View reviewed changes

new zip idea

3908bc0

jaredpar merged commit 203d11f into main Jun 23, 2023

jaredpar deleted the darc-main-0b91fd41-3be2-4e1e-81e0-c48d3d238f51 branch June 23, 2023 18:11

jaredpar added a commit that referenced this pull request Jun 23, 2023

Clean up from previous PR

24ee46f

This addresses some feedback from #8762

jaredpar mentioned this pull request Jun 23, 2023

Clean up from previous PR #8863

Merged

jaredpar added a commit that referenced this pull request Jun 23, 2023

Clean up from previous PR (#8863)

c3de764

This addresses some feedback from #8762

maryamariyan mentioned this pull request Jun 28, 2023

Fixes Microsoft.NETCore.App.Runtime Component Governance issues #8880

Merged

allisonchou mentioned this pull request Jun 30, 2023

[Automated] PRs inserted in VS build main-33829.535 #8893

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/arcade #8762

[main] Update dependencies from dotnet/arcade #8762

dotnet-maestro bot commented May 25, 2023 •

edited

Loading

ghost left a comment

davidwengier commented Jun 2, 2023

azure-pipelines bot commented Jun 2, 2023

chsienki commented Jun 15, 2023

333fred commented Jun 15, 2023

jaredpar commented Jun 16, 2023

maryamariyan commented Jun 16, 2023

jjonescz Jun 19, 2023 •

edited

Loading

nagilson commented Jun 19, 2023

baronfel left a comment

jaredpar commented Jun 22, 2023

jjonescz Jun 23, 2023

jaredpar Jun 23, 2023

jjonescz Jun 23, 2023

	<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
	<MSBuildWarningsAsMessages>NETSDK1201</MSBuildWarningsAsMessages>

[main] Update dependencies from dotnet/arcade #8762

[main] Update dependencies from dotnet/arcade #8762

Conversation

dotnet-maestro bot commented May 25, 2023 • edited Loading

From https://github.com/dotnet/arcade

Coherency Updates

ghost left a comment

Choose a reason for hiding this comment

davidwengier commented Jun 2, 2023

azure-pipelines bot commented Jun 2, 2023

chsienki commented Jun 15, 2023

333fred commented Jun 15, 2023

jaredpar commented Jun 16, 2023

maryamariyan commented Jun 16, 2023

jjonescz Jun 19, 2023 • edited Loading

Choose a reason for hiding this comment

nagilson commented Jun 19, 2023

baronfel left a comment

Choose a reason for hiding this comment

jaredpar commented Jun 22, 2023

jjonescz Jun 23, 2023

Choose a reason for hiding this comment

jaredpar Jun 23, 2023

Choose a reason for hiding this comment

jjonescz Jun 23, 2023

Choose a reason for hiding this comment

dotnet-maestro bot commented May 25, 2023 •

edited

Loading

jjonescz Jun 19, 2023 •

edited

Loading