-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/arcade #8762
Merged
jaredpar
merged 35 commits into
main
from
darc-main-0b91fd41-3be2-4e1e-81e0-c48d3d238f51
Jun 23, 2023
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
8210355
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 8f9f845
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 37493ca
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] c1e6ca2
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] fea563f
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 745fcbd
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 4846af2
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] f006549
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] e46b375
Merge branch 'main' into darc-main-0b91fd41-3be2-4e1e-81e0-c48d3d238f51
333fred 33da1be
Update Versions.props
333fred 3c12ace
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 5fab05e
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] fd82fdd
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 6a5422a
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 31f28d4
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 39d43f6
Merge remote-tracking branch 'origin/main' into darc-main-0b91fd41-3b…
e7f41f5
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 85d70a3
Skip failing tests. Tracked by https://github.com/dotnet/razor/issues…
chsienki 04732f3
Work past the self contained error
jaredpar 9ec4c6a
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 9f4a469
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] f3963df
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] a9c99b8
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] fde3470
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 3e75def
Merge remote-tracking branch 'origin/main' into darc-main-0b91fd41-3b…
jaredpar 3d699c4
Fix version diff
jaredpar 8d9b60e
Work around unsupported base image
jaredpar 254b8da
another workaround
jaredpar b7928e1
fix queue names
jaredpar eaa6538
fix container
jaredpar c337876
Update src/Razor/src/rzls/rzls.csproj
jaredpar f8497e3
More
e9d8dc3
Apply suggestions from code review
jaredpar c49335a
powershell
jaredpar 3908bc0
new zip idea
jaredpar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -6,6 +6,7 @@ | |||||
<OutputType>Exe</OutputType> | ||||||
<Description>Razor is a markup syntax for adding server-side logic to web pages. This package contains a Razor language server.</Description> | ||||||
<EnableApiCheck>false</EnableApiCheck> | ||||||
<TreatWarningsAsErrors>false</TreatWarningsAsErrors> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jaredpar to suppress the warning, you can do this:
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||||||
<RuntimeIdentifiers Condition="$([MSBuild]::IsOSPlatform('Windows'))">win-x64;win-x86;win-arm64</RuntimeIdentifiers> | ||||||
<RuntimeIdentifiers Condition="$([MSBuild]::IsOSPlatform('Linux'))">linux-x64;linux-musl-x64;linux-arm64;linux-musl-arm64</RuntimeIdentifiers> | ||||||
<RuntimeIdentifiers Condition="$([MSBuild]::IsOSPlatform('OSX'))">osx-x64;osx-arm64</RuntimeIdentifiers> | ||||||
|
@@ -58,11 +59,11 @@ | |||||
|
||||||
<!-- Transform RuntimeIdentifierForPublish items to project items to pass to MSBuild task --> | ||||||
<ProjectToPublish Include="@(RuntimeIdentifierForPublish->'$(MSBuildProjectFullPath)')"> | ||||||
<AdditionalProperties>RuntimeIdentifier=%(RuntimeIdentifierForPublish.Identity);PublishDir=$(RidsPublishDir)%(RuntimeIdentifierForPublish.Identity)\;TargetFramework=$(PublishTargetFramework)</AdditionalProperties> | ||||||
<AdditionalProperties>RuntimeIdentifier=%(RuntimeIdentifierForPublish.Identity);PublishDir=$(RidsPublishDir)%(RuntimeIdentifierForPublish.Identity)\;TargetFramework=$(PublishTargetFramework);SelfContained=true</AdditionalProperties> | ||||||
</ProjectToPublish> | ||||||
|
||||||
<ProjectToPublish_PlatformAgnostic Include="$(MSBuildProjectFullPath)"> | ||||||
<AdditionalProperties>PublishDir=$(RidsPublishDir)\PlatformAgnostic\;UseAppHost=false;TargetFramework=$(PublishTargetFramework)</AdditionalProperties> | ||||||
<AdditionalProperties>PublishDir=$(RidsPublishDir)\PlatformAgnostic\;UseAppHost=false;TargetFramework=$(PublishTargetFramework);</AdditionalProperties> | ||||||
</ProjectToPublish_PlatformAgnostic> | ||||||
</ItemGroup> | ||||||
|
||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change still needed? There don't seem to be any warnings to suppress in the latest CI builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will revert this and the other change you mentioned after merging. This finally went greenand I want to get this in to unblock other items. Those changes dont' really impact the semantics so should be fine to be in for a few hour.s