Features/fuse #10090
Merged
Features/fuse #10090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added config flag - Set flag to default to true in IDE scenarios - When flag is set, return a runtime doc, even if a design time one is requested
* Skip test * Run tests
…#9863) * Ensure we include the line count and end char index in remapped spans * Make the source span in tests have non-default values to ensure they get mapped too
* Add missing source mappings for runtime documents * Update baselines * Ensure we throw if the mapping from source to generated code doesn't match
Update @page directives to include #line and source mapping information in runtime generation.
Updates tooling to get the value LanguageServerFeatureOptions options and pass into the compiler
* Track if a using statement has an explicit semicolon Using statements can have an optional semicolon, which is added automatically if the user doesn't write one. Track if the user explicitly wrote the semicolon so we know where the user written code starts and ends. * Add missing source mappings for runtime usings Write out the semicolon if the user didn't explicitly provide it * Correctly emit enhanced line directives when there is no offset An offset of 0 is represented by the absence of an offset, not a literal 0. Don't write an offset at all if zero is requested. * Update baselines and add tests
* Use enhanced line pragmas for csharp tokens - Ensure we build a pragma around each individual token, rather than the overall node - Refactor writer to share child rendering code - Move add padding call to line pragma builder * Assert that pragmas have matching source mappings, and are enhanced. * Update tests with positions and hardcoded outputs * Update source generator test * Update baselines
* Track namespace locations: - Track the user written portion of the namespace - When there is a user written portion, build a line pragma around it * Update baselines --------- Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
* Ensure we always write a mapping when emitting a line pragma * Add assert to check that we always write an enhanced line in runtime * Track component inject user code parts * Add component inject baseline test * Update @Inject directives for extensions * Add required shim parts for MVC1x * Update baselines
Merges main into the fuse branch
jaredpar
approved these changes
Mar 13, 2024
ryzngard
approved these changes
Mar 13, 2024
jjonescz
reviewed
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use runtime code generation for the IDE when under feature flag.