Skip to content

Reduce allocations in LegacyFileKindVisitor.VisitMarkupTagHelperAttribute #11930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Reduce allocations in LegacyFileKindVisitor.VisitMarkupTagHelperAttribute #11930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions ...oft.CodeAnalysis.Razor.Compiler/src/Language/DefaultRazorIntermediateNodeLoweringPhase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,18 +1122,24 @@ public override void VisitMarkupTagHelperAttribute(MarkupTagHelperAttributeSynta
var descriptors = element.TagHelperInfo.BindingResult.Descriptors;
var attributeName = node.Name.GetContent();
var attributeValueNode = node.Value;
var associatedDescriptors = descriptors.Where(descriptor =>
descriptor.BoundAttributes.Any(attributeDescriptor => TagHelperMatchingConventions.CanSatisfyBoundAttribute(attributeName, attributeDescriptor)));

if (associatedDescriptors.Any() && _renderedBoundAttributeNames.Add(attributeName))
using var associatedDescriptorsWithSatisfyingAttribute = new PooledArrayBuilder<(TagHelperDescriptor, BoundAttributeDescriptor)>();
foreach (var descriptor in descriptors)
{
foreach (var associatedDescriptor in associatedDescriptors)
foreach (var attributeDescriptor in descriptor.BoundAttributes)
{
var associatedAttributeDescriptor = associatedDescriptor.BoundAttributes.First(a =>
if (TagHelperMatchingConventions.CanSatisfyBoundAttribute(attributeName, attributeDescriptor))
{
return TagHelperMatchingConventions.CanSatisfyBoundAttribute(attributeName, a);
});
associatedDescriptorsWithSatisfyingAttribute.Add((descriptor, attributeDescriptor));
break;
}
}
}

if (associatedDescriptorsWithSatisfyingAttribute.Any() && _renderedBoundAttributeNames.Add(attributeName))
{
foreach (var (associatedDescriptor, associatedAttributeDescriptor) in associatedDescriptorsWithSatisfyingAttribute)
{
var setTagHelperProperty = new TagHelperPropertyIntermediateNode()
{
AttributeName = attributeName,
Expand Down
Loading