Allow the source generator to produce results for miscellaneous files #12106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chsienki
approved these changes
Aug 18, 2025
|
LGTM Modulo build errors, and assuming tests then pass. |
The imports document it expected to add to was outside the project cone, which should never have worked.
|
/backport to release/dev18.0 |
|
Started backporting to release/dev18.0: https://github.com/dotnet/razor/actions/runs/17089789307 |
Merged
2 tasks
phil-allen-msft
added a commit
that referenced
this pull request
Aug 20, 2025
…iscellaneous files (#12126) Backport of #12106 to release/dev18.0 /cc @davidwengier ## Customer Impact ## Regression - [ ] Yes - [ ] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing [How was the fix verified? How was the issue missed previously? What tests were added?] ## Risk [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
This was referenced Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Razor side of dotnet/vscode-csharp#8512
Needs dotnet/roslyn#79891 for the interface definition, and to hook things up in the misc files project
Fixes #9519
Fixes #11833
This could be done as its own PR without the source generator locator service, and it would all be the same, but also impossible to hit in real life, so I just bundled it all together.