Skip to content

Allow Razor cohosting to work with non-Razor SDK projects #8559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 25, 2025
Merged

Allow Razor cohosting to work with non-Razor SDK projects #8559

merged 6 commits into from
Aug 25, 2025

Conversation

@davidwengier
Copy link
Member

@davidwengier davidwengier commented Aug 19, 2025 •
edited
Loading

Fixes dotnet/razor#11834

Razor bump to 10.0.0-preview.25424.9:
View Complete Diff of Changes

  • Update PublishData.json (PR: #12141)
  • Compiler: Reduce allocations in tag helper matching (PR: #12134)
  • Allow Razor cohosting to work with non-Razor SDK projects (PR: #12118)
  • [main] Source code updates from dotnet/dotnet (PR: #12130)
  • Update publishdata for main branch (PR: #12127)
  • Allow the source generator to produce results for miscellaneous files (PR: #12106)
  • Update versions post snap (PR: #12124)
  • Compiler: Avoid allocating strings for various variable and parameter names during code generation (PR: #12103)

Roslyn bump to 5.0.0-2.25424.1:
View Complete Diff of Changes

  • Update doc for IMethodSymbol.IsExtensionMethod (PR: #80016)
  • Don't cache known-broken compositions (PR: #80021)
  • Update PublishData.json (PR: #80019)
  • Extensions: address some follow-ups related to using directives (PR: #79890)
  • Cleanup methods in DiagAnalyzerService (PR: #80013)
  • Simplify processing of errors reported by the build (PR: #79964)
  • Additional cleanup of the DiagnosticAnalyzerServier (PR: #80005)
  • Fix Code Lens around source generated files (PR: #79992)
  • Remove superflous DiagService api that can be achieved with existing apis (PR: #80007)
  • Add RuntimeAwaitMethod to AwaitExpressionInfo (PR: #79968)
  • Expose protocol types to new Razor test assemblies (PR: #80000)
  • Generate init accessor for required properties inside readonly structs (PR: #80004)
  • Remove existing low level diag oop code now that it's all handled at higher levels. (PR: #79994)
  • Allow large InlineHint ArrayBuilder pooling (PR: #79857)
  • Reduce allocations obtaining classified spans in ClassifierHelper (PR: #79856)
  • Compute span diagnostics in oop (PR: #79991)
  • Update SemanticSearch to 18.0.634-alpha (PR: #79996)
  • Allow Razor cohosting to work with non-Razor SDK projects (PR: #79953)
  • Do not use collectible AssemblyLoadContexts in AnalyzerAssemblyLoader. (PR: #79990)
  • Move computation of deprioritized analyzers to oop (PR: #79989)
  • EnC: Fix symbol mapping of delegates with indexed name (PR: #79837)
  • Emit telemetry 'durations' with known radix point '.' (PR: #79988)
  • Move logic up into DiagService (PR: #79985)
  • Switch PR val pipeline to test signing (PR: #79973)
  • Move the StateManager type up to the DiagnosticService from the DiagnosticIncrementalANalyzer (PR: #79984)
  • Immediately remote diagnostics call to OOP (PR: #79983)
  • Re-enable incremental SDL (PR: #79977)
  • Build Microsoft.CodeAnalysis.SemanticSearch.Extension ref assembly for use in semantic search queries (PR: #79972)
  • Only cache compilation if we have the same set of analyzers (PR: #79978)
  • Modify Attribute_TypedParamsConstant_EnumArray_ConstructorArgument test to work on Mono (PR: #79955)
  • Add auto-generated to EmbeddedAttribute (PR: #79960)
  • Update publishdata for main branch (PR: #79981)
  • Delete unused property (PR: #79963)
  • Update 'use expr body' to be a purely syntactic analyzer (PR: #79979)
  • Update publishdata.json for release/dev18.0 (PR: #79974)
  • Mark 'Use expr body' as a syntax-only fixer (PR: #79971)
  • ResxSourceGenerator: Added XML comment summary to the generated classes and properties to avoid warning CS1591 if they are public (PR: #79940)
  • ?? MSBuildWorkspaceDirectory - Fallback to AppContext.BaseDirectory when Assembly Location is empty (PR: #79934)
  • Merge runtime async support into main (PR: #79833)
  • Update contributor doc (PR: #79962)
  • Implement "Simplify property accessor" feature (PR: #79754)
  • Merge main to runtime async branch (PR: #79961)
  • Redo how and when we report source generator telemetry (PR: #79951)
  • Add tests for field keyword semantic model and IOperation (PR: #79945)
  • Fix failing test case BindingAsyncTasklikeMoreTests.Dynamic on Mono (PR: #79878)
  • Update yml files to use community branch (PR: #79950)
  • ResxSourceGenerator: Changed the access modifier of the generated format methods from "internal" to "public" as it is with the generated properties. (PR: #79941)
  • Fix results streamed by ForAttributeWithMetadataName with multiple parts (PR: #79947)
  • Allow MEF components to supply assembly path resolvers (PR: #79218)
  • update auto merge config (PR: #79949)
  • Allow Razor to hook up the source generator in misc files (PR: #79891)
  • Update PublishData.json (PR: #79946)
  • Reorder checks to report issue as early as possible (PR: #79915)
  • Update localization branch to 17.14 (PR: #79918)
  • Avoid crash from Script class instantiation (PR: #79879)
  • Unblock type forwarding scenarios involving extensions (PR: #79905)
  • Fix nullable annotations of SymbolDisplay.FormatPrimitive (PR: #79869)
  • Extensions: Address follow-ups related to collection expressions (PR: #79877)
  • Block ENC for extension blocks (PR: #79883)
  • Upgrade servicehub.client to fix test source discovery (PR: #79899)
  • [main] Source code updates from dotnet/dotnet (PR: #79889)
  • Fix ref safety of implicit calls that might capture refs in the receiver (PR: #76657)
  • Update package restore error message. (PR: #79876)
  • Reenable/Fix integration test reporting (PR: #79789)
  • Update checklist for adding new language version (PR: #79881)
  • Merge main (PR: #79834)
  • Merge main (PR: #79830)
  • Baseline struct lifting tests (PR: #79505)
  • Merge main to runtime async branch (PR: #79582)
  • Merge main (PR: #79424)
  • Support using a simple overload resolution for finding Await helpers from the BCL (PR: #79135)
  • Exception Handler support (PR: #78773)
  • Merge main (PR: #78994)
  • Merge main to runtime async branch (PR: #78740)
  • Ensure return local is the correct type for runtime async (PR: #78603)
  • Switch MethodImplAttributes.Async to 0x2000 (PR: #78536)
  • Merge main to runtime async branch (PR: #78517)
  • Move runtime async method validation into initial binding (PR: #78310)
  • Implement custom awaitable support (PR: #78071)
  • Merge main to runtime async branch (PR: #78114)
  • Merge main to runtime async branch (PR: #77700)
  • Add RuntimeAsyncMethodGenerationAttribute (PR: #77543)
  • Merge main to runtime async branch (PR: #77533)
  • Merge main to runtime async branch (PR: #77265)
  • Handle basic await scenarios (PR: #76121)

@davidwengier davidwengier marked this pull request as ready for review August 20, 2025 04:17
@davidwengier davidwengier requested a review from a team as a code owner August 20, 2025 04:17
jasonmalinowski
jasonmalinowski reviewed Aug 21, 2025
View reviewed changes
src/lsptoolshost/server/roslynLanguageServer.ts
Comment on lines +711 to +712
// Razor has code in Microsoft.CSharp.DesignTime.targets to handle non-Razor-SDK projects, but that doesn't get imported outside
// of DevKit so we polyfill with a mini-version that Razor provides for that scenario.
Copy link
Member

@jasonmalinowski jasonmalinowski Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't we importing the same support directly?

Copy link
Member Author

@davidwengier davidwengier Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In DevKit the targets file comes from the Microsoft.VisualStudio.ProjectSystem.Managed package which we don't reference in the C# extension. Seemed like a large hammer for one xml file. We'd still need all of the changes in this PR anyway, to pass the path through to msbuild etc. it would just be path itself that would change.

Copy link
Member

@dibarbet dibarbet Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume we also need this for C# standalone scenarios, when devkit isn't available?

Copy link
Member Author

@davidwengier davidwengier Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thats the only scenario this code runs in. With DevKit, we leave it up to it.

@davidwengier
Copy link
Member Author

davidwengier commented Aug 25, 2025

Bumped Razor and Roslyn, so this should build now (and work!)

@davidwengier davidwengier requested a review from dibarbet August 25, 2025 04:17
JoeRobich
JoeRobich reviewed Aug 25, 2025
View reviewed changes
@davidwengier @JoeRobich
Update CHANGELOG.md
6eee942 
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
@davidwengier davidwengier enabled auto-merge August 25, 2025 23:25
@davidwengier davidwengier merged commit a11b972 into dotnet:main Aug 25, 2025
32 checks passed
@davidwengier davidwengier deleted the RazorWithNonRazorSdkProjects branch August 25, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski left review comments

@JoeRobich JoeRobich JoeRobich approved these changes

@dibarbet dibarbet dibarbet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automatic AdditionalFiles and source generator reference in non-Razor SDK projects

4 participants

@davidwengier @jasonmalinowski @JoeRobich @dibarbet