Redo how and when we report source generator telemetry

[jasonmalinowski]

Previously, we were triggering a report of source generator telemetry when the user closed the solution. The intent of this was to be able to do it prior to "context" that the telemetry service has set is cleared; this means we could understand the performance for one solution versus another.

This approach however was broken once we moved the computation of source generators OOP; this meant we'd report the 'in-process' results, which are almost always empty.

This switches to reporting the results for all out-of-process and in- process runs. Unfortunately, the trick of us doing it during solution close isn't possible without blocking the UI thread synchronously on OOP which we don't want to do, so for now we'll just report telemetry every few minutes as long as there's new telemetry to report. There is work happening that would allow us to have an asynchronous handler there again which we can look at moving back to later.

[AbhitejJohn]

LGTM, I'm thinking of the volume of telemetry data this would bring in. Maybe there's precedent to some of that already though? However it would be nice if we had something tracking this:

There is work happening that would allow us to have an asynchronous handler there again which we can look at moving back to later.

[CyrusNajmabadi]

will review tomorrow :)

[jasonmalinowski]

LGTM, I'm thinking of the volume of telemetry data this would bring in.

We're only sending telemetry every five minutes, and only if there is something to report. I intentionally did a bit of extra work so we'll go idle if the user has VS running in a way they forgot about, we're not going to keep pinging their CPU just to do nothing. I'd generally expect that in an active VS session we're going to be firing up a lot of more telemetry events in response to user events....

[CyrusNajmabadi]

signing off with some minor feedback. i leave it to you if you want to take it.

[jasonmalinowski]

@CyrusNajmabadi Feedback was good, thank you!