Merge main to runtime async branch #77533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Parse partial events and constructors * Update pre-existing tests * Explain why partial ctors are sometimes disallowed * Parse `partial` constructors unconditionally * Gate parsing on LangVersion * Extend tests and docs * Fix indentation * Rename combinatorial values * Test more lang versions * Parse partial events unconditionally
…ence-packages build 20250203.2 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.607901 -> To Version 10.0.610302
…ence-packages build 20250204.2 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.607901 -> To Version 10.0.610402
* Partial events and constructors: merge and check symbols * Improve code * Move partial availability check * Improve code * Fix duplicate definition diagnostic * Test different ordering * Avoid reporting diagnostic for escaped `partial` * Clarify naming of AccessorsHaveImplementation property * Add event definition accessor symbol * Improve code * Test sequence points * Test extern IL * Fix interface container diagnostics * Fix sequence points issue in the test utility * Ensure the new accessor owner is a definition
…ence-packages build 20250210.2 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.607901 -> To Version 10.0.611002
…211.5 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.XliffTasks From Version 9.0.0-beta.25077.4 -> To Version 9.0.0-beta.25111.5
* Partial events and constructors: check differences * Improve code and tests * Complete constructor implementation part * Report error for tuple differences in constructors
…ence-packages build 20250212.3 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.608004 -> To Version 10.0.611203
This pull request updates the following dependencies [marker]: <> (Begin:111cfc79-5f9f-4acd-d8a2-08dc0c5899fd) ## From https://github.com/dotnet/arcade - **Subscription**: 111cfc79-5f9f-4acd-d8a2-08dc0c5899fd - **Build**: 20250211.5 - **Date Produced**: February 11, 2025 11:57:34 PM UTC - **Commit**: 5da211e1c42254cb35e7ef3d5a8428fb24853169 - **Branch**: refs/heads/release/9.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.SourceBuild.Intermediate.arcade**: [from 9.0.0-beta.25077.4 to 9.0.0-beta.25111.5][1] - **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.25077.4 to 9.0.0-beta.25111.5][1] - **Microsoft.DotNet.Helix.Sdk**: [from 9.0.0-beta.25077.4 to 9.0.0-beta.25111.5][1] - **Microsoft.DotNet.XliffTasks**: [from 9.0.0-beta.25077.4 to 9.0.0-beta.25111.5][1] [1]: dotnet/arcade@bac7e1c...5da211e [DependencyUpdate]: <> (End) - **Updates to .NET SDKs:** - Updates sdk.version to 9.0.103 - Updates tools.dotnet to 9.0.103 [marker]: <> (End:111cfc79-5f9f-4acd-d8a2-08dc0c5899fd)
…ence-packages build 20250218.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.608004 -> To Version 10.0.611801
Co-authored-by: Cyrus Najmabadi <cyrus.najmabadi@gmail.com>
…expression to an implicit object creation expression
…deAnalysis.CSharp.txt
* Partial events and constructors: attributes * Update pre-existing tests * Fixup expected PEVerify output * Check a flag before materializing syntax nodes * Assert that the definition part of an event doesn't have accessors * Keep pre-existing event attribute target behavior * Improve code * Add WorkItem attribute * Strengthen asserts Co-authored-by: Rikki Gibson <rikkigibson@gmail.com> --------- Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
This shouldn't be needed anymore, and prevents some design time build breaks if NuGet restore wasn't able to get this package. Fixes dotnet#74923
The MSBuild task invocation here is a copy/paste from earlier in the file, but the item group renamed so it didn't conflict. The rename was in complete, so the use in the Properties property was still using the old name; this had the effect that we wouldn't set the TFM property, which would cause problems for multi-targeting projects.
The MSBuild task invocation here is a copy/paste from earlier in the file, but the item group renamed so it didn't conflict. The rename was in complete, so the use in the Properties property was still using the old name; this had the effect that we wouldn't set the TFM property, which would cause problems for multi-targeting projects.
…ence-packages build 20250306.1 (dotnet#77470) Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.615503 -> To Version 10.0.615601 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
# Problem Rename flyout is being cropped on small screens. The issue being that: 1. The flyout is larger than the document's view port 2. The flyout's left position is negative (which makes it disappear to the left). 3. Text within the flyout doesn't wrap.  # Solution Basically, address all of the above: 1. Limit the size of the flyout to the width of the document's view port. 2. Ensure the flyout's position is always positive. 3. Wrap text blocks. 
This shouldn't be needed anymore, and prevents some design time build breaks if NuGet restore wasn't able to get this package. Fixes dotnet#74923
…ence-packages build 20250310.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.615601 -> To Version 10.0.616001
dotnet#77518) This pull request updates the following dependencies [marker]: <> (Begin:4e88e544-5668-4a45-0f48-08dc0c57b4c0) ## From https://github.com/dotnet/source-build-reference-packages - **Subscription**: 4e88e544-5668-4a45-0f48-08dc0c57b4c0 - **Build**: [20250310.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2659508) - **Date Produced**: March 10, 2025 4:22:48 PM UTC - **Commit**: [8f9f6fa14523b2f2475ea0a86be1cf60b5de5336](dotnet/source-build-reference-packages@8f9f6fa) - **Branch**: refs/heads/main [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.SourceBuild.Intermediate.source-build-reference-packages**: [from 10.0.615601 to 10.0.616001][1] [1]: dotnet/source-build-reference-packages@232bcf3...8f9f6fa [DependencyUpdate]: <> (End) [marker]: <> (End:4e88e544-5668-4a45-0f48-08dc0c57b4c0)
* upstream/main: (134 commits) Mark partial events and ctors as complete (dotnet#77525) Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250310.1 Remove unnecessary imports Update dev18 target branch (dotnet#77443) Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250306.1 (dotnet#77470) Remove BoundConversion.OriginalUserDefinedConversionsOpt property (dotnet#77465) Addressed feedback [Rename flyout] Fixed cropping issue on small screens Fix design time build error in Roslyn.VisualStudio.Setup Remove workaround of WPF bug Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250305.3 (dotnet#77452) Small cleanup in the packages and editor factories (dotnet#77439) Auto merge PRs instead of just applying a label to them (dotnet#77438) Fix bot name (dotnet#77436) Add workitem Don't use an implicit-object if the lang version doesn't support it Configure main-vs-deps (dotnet#77408) Fix projects File scoped namespace Update formatting tests ...
dotnet-policy-service
bot
added
VSCode
Needs API Review
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
jcouv
approved these changes
Mar 11, 2025
333fred
merged commit c641c52
into
dotnet:features/runtime-async
26 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge main to the feature branch