Skip to content

Conversation

@uo-uhbc
Copy link
Contributor

@uo-uhbc uo-uhbc commented Aug 18, 2025

Changed the access modifier of the format methods from "internal" to "public", like the generated properties are.
That also make it possible to access to those format methods from other assemblies, when the class is generated as public.

Fixes dotnet/roslyn-analyzers#7452

This is the replacement for dotnet/roslyn-analyzers#7360 since the ResxSourceGenerator have been moved to this repository.

@uo-uhbc uo-uhbc requested a review from a team as a code owner August 18, 2025 07:36
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Aug 18, 2025
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @uo-uhbc!

@JoeRobich JoeRobich merged commit 30d0256 into dotnet:main Aug 19, 2025
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 19, 2025
@uo-uhbc uo-uhbc deleted the bugfix/generated-format-methods.public branch August 19, 2025 07:06
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Analyzers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ResxSourceGenerator does not generate public format methods when Public="true" is set

4 participants