Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Compiler features in Project Engine #8172

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

ryanbrandenburg
Copy link
Contributor

Summary of the changes

  • As per @333fred and my investigations it seems that we weren't registering the CompilerFeatures in the non-legacy factory.
  • Also added an Integration test for this scenario. Partially to confirm this is fixed, but also as a hedge against reoccurrence since we were unable to determine a root cause for the sudden behavior change (IE: How did this ever work?).

Fixes: #7966

@ryanbrandenburg ryanbrandenburg requested a review from a team as a code owner January 24, 2023 20:11
@davidwengier
Copy link
Member

I would love to know what changed, and why, to cause this to be picked up, but I think this is objectively the right fix regardless of the outcome of that investigation.

@ryanbrandenburg ryanbrandenburg merged commit ee76f59 into dotnet:main Jan 24, 2023
@ryanbrandenburg ryanbrandenburg deleted the RazorProjectEngine branch January 24, 2023 21:53
@allisonchou
Copy link
Contributor

@333fred @ryanbrandenburg I implemented the same fix in the VSCode branch a few weeks ago - #8061

Seeing merge conflicts now between the feature branch and main. I'm going to take the feature branch version if that's OK with you two.

@allisonchou
Copy link
Contributor

Actually, after talking to Ryan separately, it sounds like maybe the main branch fix is the right one to pick since it's the one going through QB. Will edit the feature branch code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components with generic type parameters don't work in the experimental instance
4 participants