Include Compiler features in Project Engine #8173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanbrandenburg I implemented the same fix in the VS Code feature branch a few weeks ago: #8061 I think the feature branch version seems a bit cleaner, but let me know your thoughts. |
|
Talked with @allisonchou offline. Due to tight timelines we're gonna take the version of the fix that is currently in the main branch, but if people feel strongly it's totally reasonable to file an issue to re-visit our abstraction here since at this point I believe we've consulted 4 engineers and gotten 4 different answers on the "right" place to put it. |
|
Yep. Tracking issue is #8064 |
allisonchou
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes