Transport EA.RazorCompiler DLL #8824
Conversation
| @@ -12,13 +12,18 @@ | |||
| <ExcludeFromSourceBuild>false</ExcludeFromSourceBuild> | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler" ExcludeAssets="all" GeneratePathProperty="true" /> | |||
| </ItemGroup> | |||
There was a problem hiding this comment.
This file is more or less inlining the transitive reference. Rather than having a transitive reference it's just unpacking the NuPgk and re-packing the content.
Why are we taking this approach here? Why doesn't a transitive reference work?
There was a problem hiding this comment.
I assumed that's the point of transport packages - they pack all the needed DLLs together, without relying on standard project/package references.
There was a problem hiding this comment.
Possible. Do the other transport packages work this way?
There was a problem hiding this comment.
I'm only familiar with Razor transport packages, and yes, that's my understanding. Although they don't contain PackageReferences as far as I'm aware (only ProjectReferences), this is the first one. I mean - they technically depend on MS.CA.CSharp package, but that probably doesn't have to be packed, since it's made available by the SDK anyway (by the project where the transport flows).
Fixes errors in dotnet/sdk#33125.