Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0.4xx] Update dependencies from dotnet/razor #33125

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 8, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/razor

  • Subscription: 2718ba3d-9ef7-4231-e532-08db30952842
  • Build: 20230613.3
  • Date Produced: June 14, 2023 12:34:44 AM UTC
  • Commit: cba27feaa6097cdc1e214b4f9d9ed03059eea5cc
  • Branch: refs/heads/main

…08.1

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23308.1
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Jun 8, 2023
@JL03-Yue
Copy link
Member

JL03-Yue commented Jun 8, 2023

@dotnet/aspnet-blazor-eng Can you please take a look at the error in here? It seems that the tests are triggering warnings unexpected.

cc @baronfel

dotnet-maestro bot added 6 commits June 8, 2023 23:53
…08.3

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23308.3
…08.4

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23308.4
…09.1

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23309.1
…09.2

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23309.2
…09.3

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23309.3
…09.4

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23309.4
@v-wuzhai
Copy link
Member

@dotnet/razor-compiler Can you please take a look at the error in here?

@jjonescz
Copy link
Member

I see error

CSC : warning CS8784: Generator 'RazorSourceGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler, Version=4.7.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified. [/datadisks/disk1/work/B19C096A/w/B65109A9/e/testExecutionDirectory/Publish60Host---0200F604/Client/BlazorWasmHosted60.Client.csproj]

This PR should fix that: dotnet/razor#8824

dotnet-maestro bot added 2 commits June 13, 2023 01:41
…08.2

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23308.2
…12.9

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23312.9
@JL03-Yue
Copy link
Member

@jjonescz Can you please take a look at the error here? It seems that some work items are failing after the fix.

dotnet-maestro bot and others added 4 commits June 13, 2023 19:01
…13.1

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23313.1
…13.2

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23313.2
…13.3

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23313.3
Needed to ignore `Microsoft.AspNetCore.Razor.Utilities.Shared`.
@jjonescz
Copy link
Member

jjonescz commented Jun 14, 2023

The error is

Extension assembly 'Microsoft.AspNetCore.Mvc.Razor.Extensions' depends on 'Microsoft.AspNetCore.Razor.Utilities.Shared, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60 which is missing.
Extenions could not be loaded. See output for details.

Seems to be caused by dotnet/razor#8812. Before that PR, Microsoft.AspNetCore.Mvc.Razor.Extensions.dll didn't have Microsoft.AspNetCore.Razor.Utilities.Shared as dependency, after that PR, it did.

The new dependency fails in Microsoft.NET.Sdk.Razor.Tool here:

_error.WriteLine($"Extension assembly '{item.Identity.Name}' at '{item.FilePath}' has a different ModuleVersionId than loaded assembly '{item.Assembly.FullName}'");

Not sure how it's supposed to work, but pushed a possible fix which makes the tool recognize and ignore the Microsoft.AspNetCore.Razor.Utilities.Shared dependency.

@333fred
Copy link
Member

333fred commented Jun 15, 2023

@marcpopMSFT could you take a look at this?

@marcpopMSFT
Copy link
Member

Was waiting to see if @mkArtakMSFT or @captainsafia wanted to review since it contained test changes. Approving since it's passing checks and then can review after the fact if there are concerns

@dotnet-maestro dotnet-maestro bot merged commit 4f43806 into release/7.0.4xx Jun 15, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-release/7.0.4xx-13c6650b-0ba6-4117-b923-9be62cbd5228 branch June 15, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants