-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0.4xx] Update dependencies from dotnet/razor #33125
[release/7.0.4xx] Update dependencies from dotnet/razor #33125
Conversation
…08.1 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23308.1
@dotnet/aspnet-blazor-eng Can you please take a look at the error in here? It seems that the tests are triggering warnings unexpected. cc @baronfel |
…08.3 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23308.3
…08.4 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23308.4
…09.1 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23309.1
…09.2 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23309.2
…09.3 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23309.3
…09.4 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23309.4
@dotnet/razor-compiler Can you please take a look at the error in here? |
I see error CSC : warning CS8784: Generator 'RazorSourceGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler, Version=4.7.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified. [/datadisks/disk1/work/B19C096A/w/B65109A9/e/testExecutionDirectory/Publish60Host---0200F604/Client/BlazorWasmHosted60.Client.csproj]
This PR should fix that: dotnet/razor#8824 |
…08.2 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23308.2
…12.9 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23312.9
@jjonescz Can you please take a look at the error here? It seems that some work items are failing after the fix. |
…13.1 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23313.1
…13.2 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23313.2
…13.3 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 7.0.0-preview.23307.4 -> To Version 7.0.0-preview.23313.3
Needed to ignore `Microsoft.AspNetCore.Razor.Utilities.Shared`.
The error is
Seems to be caused by dotnet/razor#8812. Before that PR, The new dependency fails in
Not sure how it's supposed to work, but pushed a possible fix which makes the tool recognize and ignore the |
@marcpopMSFT could you take a look at this? |
Was waiting to see if @mkArtakMSFT or @captainsafia wanted to review since it contained test changes. Approving since it's passing checks and then can review after the fact if there are concerns |
This pull request updates the following dependencies
From https://github.com/dotnet/razor