-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy editor shim layer #8941
Merged
Merged
Legacy editor shim layer #8941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
approved these changes
Jul 11, 2023
src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/ClassifiedSpan.cs
Show resolved
Hide resolved
chsienki
reviewed
Jul 11, 2023
...oft.VisualStudio.RazorExtension/Microsoft.VisualStudio.RazorExtension_vp20edrb_wpftmp.csproj
Outdated
Show resolved
Hide resolved
chsienki
reviewed
Jul 11, 2023
src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/RazorWrapperFactory.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/RazorWrapperFactory.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/RazorWrapperFactory.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/RazorWrapperFactory.cs
Show resolved
Hide resolved
333fred
reviewed
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good. A few questions/suggestions.
src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/InterlockedOperations.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/Extensions.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/RazorServices.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/RazorSourceSpan.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudio.Editor.Razor/RazorIndentationFacts.cs
Outdated
Show resolved
Hide resolved
davidwengier
approved these changes
Jul 11, 2023
chsienki
approved these changes
Jul 12, 2023
333fred
reviewed
Jul 12, 2023
src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/RazorSourceSpan.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/RazorWrapperFactory.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor/RazorWrapperFactory.cs
Outdated
Show resolved
Hide resolved
…Editor/RazorSourceSpan.cs Fix whitespace Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
@333fred: I believe I've addressed all of your feedback. Let me know if you have any other concerns. Thanks! |
333fred
approved these changes
Jul 13, 2023
3 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a shim layer for the Razor legacy editor to insulate the legacy editor from upcoming structural and API changes.
The approach taken here is to expose new internal types to the legacy editor via an "external access" assembly. Those internal types wrap existing Razor types without exposing them. Most of the "magical code" is in
RazorWrapperFactory.cs
. Care has been taken to avoid exposing any of the dependencies of that assembly so that the legacy editor doesn't transitively reference the compiler or tooling layers.Next steps: