Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Razor compiler code into a single DLL #8400

Closed
20 of 26 tasks
jjonescz opened this issue Mar 7, 2023 · 1 comment · Fixed by #9956
Closed
20 of 26 tasks

Consolidate Razor compiler code into a single DLL #8400

jjonescz opened this issue Mar 7, 2023 · 1 comment · Fixed by #9956
Assignees
Labels
area-compiler Umbrella for all compiler issues bug Something isn't working

Comments

@jjonescz
Copy link
Member

jjonescz commented Mar 7, 2023

Merge the following DLLs into one (Microsoft.CodeAnalysis.Razor.Compiler):

  • Microsoft.AspNetCore.Razor.Language (move into folder Language)
  • Microsoft.CodeAnalysis.Razor (move into folder CSharp)
  • Microsoft.NET.Sdk.Razor.SourceGenerators (move into folder SourceGenerators)
  • Microsoft.AspNetCore.Mvc.Razor.Extensions (move into folder Mvc)

Merge tests into one project, as well (Microsoft.CodeAnalysis.Razor.Compiler.Tests).

Roadmap:

Old plan:
To allow servicing of the old compiler (branch `release/dev17.6`): Not needed, I think, since we have shims now (#8941)

Note To service the old compiler: update the 17.6 branch, release new version of this old package, update main branch to consume that version of the old package, build and insert into VS.

See also:

@jjonescz jjonescz added the area-compiler Umbrella for all compiler issues label Mar 7, 2023
@ghost ghost added the untriaged label Mar 7, 2023
@chsienki chsienki added this to the 17.6 P3 milestone Mar 9, 2023
@ghost ghost removed the untriaged label Mar 9, 2023
@chsienki chsienki removed this from the 17.6 P3 milestone Mar 9, 2023
@ghost ghost added the untriaged label Mar 9, 2023
@chsienki chsienki removed the untriaged label Mar 9, 2023
@ghost ghost added the untriaged label Mar 9, 2023
@ghost ghost added the untriaged label Apr 13, 2023
@jaredpar jaredpar added bug Something isn't working and removed untriaged labels Apr 13, 2023
@ghost ghost added the untriaged label Apr 13, 2023
@chsienki chsienki added this to the 17.7 P2 milestone Apr 27, 2023
@ghost ghost removed the untriaged label Apr 27, 2023
@jaredpar
Copy link
Member

Integration tests are blocked on dotnet/dnceng#563

@chsienki chsienki added this to the 17.9 Planning milestone Oct 11, 2023
jjonescz added a commit that referenced this issue Feb 21, 2024
Resolves #8400.

Tests are still separate (merging them can be done in another PR or
never as it's just lots of work with no clear benefit).

Commit-by-commit review might be beneficial ("Move *" commits should not
contain anything but corresponding file moves).

VS insertion:
https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/530044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-compiler Umbrella for all compiler issues bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants