-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate Razor compiler code into a single DLL #8400
Labels
Milestone
Comments
ghost
added
the
untriaged
label
Mar 7, 2023
ghost
removed
the
untriaged
label
Mar 9, 2023
ghost
added
the
untriaged
label
Mar 9, 2023
ghost
added
the
untriaged
label
Mar 9, 2023
This was referenced Mar 20, 2023
This was referenced Apr 12, 2023
ghost
added
the
untriaged
label
Apr 13, 2023
ghost
added
the
untriaged
label
Apr 13, 2023
ghost
removed
the
untriaged
label
Apr 27, 2023
Integration tests are blocked on dotnet/dnceng#563 |
This was referenced Aug 25, 2023
This was referenced Sep 11, 2023
This was referenced Oct 20, 2023
Closed
jjonescz
added a commit
that referenced
this issue
Feb 21, 2024
Resolves #8400. Tests are still separate (merging them can be done in another PR or never as it's just lots of work with no clear benefit). Commit-by-commit review might be beneficial ("Move *" commits should not contain anything but corresponding file moves). VS insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/530044
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Merge the following DLLs into one (
Microsoft.CodeAnalysis.Razor.Compiler
):Microsoft.AspNetCore.Razor.Language
(move into folderLanguage
)Microsoft.CodeAnalysis.Razor
(move into folderCSharp
)Microsoft.NET.Sdk.Razor.SourceGenerators
(move into folderSourceGenerators
)Microsoft.AspNetCore.Mvc.Razor.Extensions
(move into folderMvc
)Merge tests into one project, as well (
Microsoft.CodeAnalysis.Razor.Compiler.Tests
).Roadmap:
Microsoft.AspNetCore.Mvc.Razor.Extensions
v1 and v2 into SDK and makerzc.dll
tool use them.Fixup runtime compilation which lives in aspnetcore.Runtime compilation is fixed to v6.0 of Razor.Old plan:
To allow servicing of the old compiler (branch `release/dev17.6`):Not needed, I think, since we have shims now (#8941)See also:
The text was updated successfully, but these errors were encountered: