Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main into features/single-compiler-dll #8591

Merged
merged 179 commits into from
May 11, 2023
Merged

Merge main into features/single-compiler-dll #8591

merged 179 commits into from
May 11, 2023

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Apr 12, 2023 •
edited
Loading

Part of #8400.

Only commits after "Merge main into features/single-compiler-dll" contain changes (the merge commit itself has no changes).

The changes are mostly because there's a single test project now and

  • since Render and verify Razor Page HTML in tests #8435 the project references ASP.NET Core SDK, but some older tests rely on shims;
  • netfx / netcore mismatch (e.g., source generator tests were written only for netcore, so have to be disabled in netfx-flavor of the test project).

davidwengier and others added 30 commits March 17, 2023 14:36
@davidwengier
Don't register a diagnsotics publisher if we don't need to
223fead
@davidwengier
Report razor compiler diagnostics in pull diagnostics
8043acf
@davidwengier
Clean up endpoint
4ca1126
@davidwengier
Remove usings
0535904
@davidwengier
Don't normalize URIs that we send to language servers
4cb0d29
@davidwengier
Remove unused overload
f7d4831
@davidwengier
Don't normalize URIs we send to language servers
8af5c00
@davidwengier
Remove unused method
72bc4bc
@davidwengier
Rename method
969abaa
@davidwengier
Merge pull request dotnet#8453 from davidwengier/PullDiagnosticsAllIn
a3a026f
@davidwengier
Merge pull request dotnet#8466 from davidwengier/HandlePathsWithHashes
789efc6
@davidwengier
Clean up document highlight
b0540c8
@davidwengier
Clean up wrap with tag
f43dad6
@davidwengier
Clean up linked editing range
40ea8b2
@davidwengier
Clean up debugging
e085448
@davidwengier
Clean up diagnostics
00ff67a
@davidwengier
Clean up document synchronization
8cdf48c
@davidwengier
Clean up formatting
e17d0f9
@allisonchou
Revert "Merge pull request dotnet#8422 from dotnet/binding-redirect" (d…
012e1d7 
…otnet#8482)

This reverts commit bf5d35e, reversing
changes made to c12b6f3.
@DustinCampbell
Add more runtime checks to ComparerUtilities
fd8abcb 
There was a recent regression in TagHelperDescriptorComparer due to
several collections in the Default* tag helper classes becoming
immutable collections. There was already a fast path for
Dictionary<TKey, TValue> to avoid boxing struct-based enumerators
and the same path is now needed for ImmutableDictionary<TKey, TValue>.

In addition, a fast path for arrays has been added to avoid calling
unnecessarily through IReadOnlyList<T>.
@DustinCampbell
Don't assume dictionaries enumerate in the same order
bc73ac8
@333fred
Escape component parameters named keywords in design time (dotnet#8448)
ffe7b5c 
* Escape component parameters named keywords in design time

We weren't escaping componet parameter names when those names were C# keywords, resulting in bad design time code. We now escape them to ensure correct document generation. Fixes https://developercommunity.visualstudio.com/t/Razor-editor-show-tons-of-errors-on-ever/10303977.
@ryzngard
Add archived feeds (dotnet#8484)
ed1242f
@adamint
Strip generic type params from rename codeaction
b92ef29
@adamint
Change visibility to internal from public
9e391ee
@davidwengier
Merge pull request dotnet#8475 from davidwengier/DocSync
24770f9
@davidwengier
Merge pull request dotnet#8478 from davidwengier/LinkedEditingRange
066c473
@davidwengier
Merge pull request dotnet#8477 from davidwengier/CleanupWrapWithTag
79ca6b7
@davidwengier
Merge pull request dotnet#8479 from davidwengier/Debugging
f1adc86
@davidwengier
Merge pull request dotnet#8474 from davidwengier/Diagnostics
b9cde96
dotnet-maestro bot and others added 13 commits April 6, 2023 14:50
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
0ee9923 
…405.4

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23171.2 -> To Version 8.0.0-beta.23205.4
@dotnet-bot
Merge pull request dotnet#8535 from dotnet/merges/release/dev17.7-to-…
4279a8e 
…main

Merge release/dev17.7 to main
@davidwengier
Package compiler dependencies in the package (dotnet#8576)
2c3e34f
@davidwengier
Merge pull request dotnet#8574 from davidwengier/UpdateDocs
f416828
@davidwengier
Merge pull request dotnet#8501 from dotnet/darc-main-d2180dc8-bb2b-42…
bc71148 
…09-b241-3f9cfe3d53cd

[main] Update dependencies from dotnet/arcade
@maryamariyan
Adds benchmark using RazorCodeActionsBenchmark as template
85dc14b
@maryamariyan
- Adds benchmark for diagnostics
243af55 
- Making tweaks to make the diagnostics benchmark work
@maryamariyan
Apply PR feedback
72fcd76
@davidwengier
Enable Public API analyzer (dotnet#8571)
0b913ce 
* Enablee Public API analyzer

The public API analyzer was not running for all intended projects due to
a global disable. Removing that, fixing the immediate violations. Using
this PR to track anymore that may have been missed

* Update public API

---------

Co-authored-by: David Wengier <git@wengier.com>
@DustinCampbell
Reference MS.Ext.ObjectPool package in ExternalAccess.RoslynWorkspace
2d7e3a7 
This package must be referenced because Roslyn doesn't include it.
@maryamariyan
Merge pull request dotnet#8580 from dotnet/benchmark-diagnostics
e4d1d7d 
Adds Benchmark for Diagnostics
@DustinCampbell
Merge pull request dotnet#8586 from DustinCampbell/fix-externalaccess…
9ccc828 
…-roslynworkspace

Reference MS.Ext.ObjectPool package in ExternalAccess.RoslynWorkspace
@jjonescz
Merge main into features/single-compiler-dll
bc3121d
@jjonescz jjonescz added the area-compiler Umbrella for all compiler issues label Apr 12, 2023
@jjonescz jjonescz marked this pull request as ready for review April 13, 2023 16:59
@jjonescz jjonescz requested review from a team as code owners April 13, 2023 16:59
@jjonescz
Copy link
Member Author

@dotnet/razor-compiler PTAL

@jjonescz
Copy link
Member Author

jjonescz commented Apr 20, 2023 •
edited
Loading

@dotnet/razor-compiler @jaredpar PTAL

@jjonescz jjonescz merged commit 3464efb into dotnet:features/single-compiler-dll May 11, 2023
@jjonescz jjonescz deleted the 8400-merge-main branch May 11, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsienki chsienki chsienki approved these changes

Assignees
No one assigned
Labels
area-compiler Umbrella for all compiler issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.