Address CA1862 cases to diagnose and to fix and improve messages

[carlossanlop]

• Modify unit tests to fix the cases that should only offer a diagnostic but no fix.
• Add comments to the unit tests to more easily find the test cases.
• Fix the analyzer and fixer logic.
• Improve the messages.

The two main changes are:

• That we won't offer a fix when the user combines cultures (for example: ToUpper vs ToUpperInvariant).
• The description has a warning for the user that they need to test the fix if they decide to apply it, or use Ordinal if needed.

[tarekgh]

LGTM. Thanks @carlossanlop for getting this done!

Will be good if @buyaa-n can take a look too.

[mavasani]

LGTM, thanks!

[carlossanlop]

There are a lot of failures in the CI that Visual Studio is not showing. I was able to see them in my local machine by running the tests in the console using dotnet test.

Very frustrating. Between this blind spot and the Roslyn suggestions that show up in CI but not in the IDE, the experience has been painful with Visual Studio.

[carlossanlop]

OK I figured out the problem. The tests that are failing are the ones where the arguments are named and they are passed unordered.

• In C#, the order passed by the user is respected when retrieving them from IInvocationOperation.Arguments.
• But in Visual Basic, IInvocationOperation.Arguments reorders the arguments to their original order as defined in the method signature.

The C# tests are currently failing because I thought both languages restored the order to the original one, but C# needs to respect the order passed by the user.

I will split the tests and will provide different expected data for VB and in C#.

[codecov]

Codecov Report

Merging #6928 (b54971d) into main (f2007ac) will decrease coverage by 0.01%.
Report is 13 commits behind head on main.
The diff coverage is 94.64%.

@@            Coverage Diff             @@
##             main    #6928      +/-   ##
==========================================
- Coverage   96.40%   96.39%   -0.01%     
==========================================
  Files        1396     1402       +6     
  Lines      330443   332159    +1716     
  Branches    10891    11061     +170     
==========================================
+ Hits       318564   320195    +1631     
- Misses       9152     9195      +43     
- Partials     2727     2769      +42     

[carlossanlop]

Finally, green CI! 🎉

[buyaa-n]

Added some comment mostly for messaging, overall LGTM, thank you!

[carlossanlop]

/backport to release/8.0

[github-actions]

Started backporting to release/8.0: https://github.com/dotnet/roslyn-analyzers/actions/runs/6205295902

[github-actions]

@carlossanlop an error occurred while backporting to release/8.0, please check the run log for details!

Error: The specified backport target branch release/8.0 wasn't found in the repo.

[carlossanlop]

/backport to release/8.0.1xx

[github-actions]

Started backporting to release/8.0.1xx: https://github.com/dotnet/roslyn-analyzers/actions/runs/6205301140