[release/8.0.1xx] Address CA1862 cases to diagnose and to fix and improve messages #6948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@jeffhandley @ericstj @artl93 can you please consider this backported fix for release/8.0.1xx? |
carlossanlop
added
the
servicing-consider
Codecov Report
@@ Coverage Diff @@
## release/8.0.1xx #6948 +/- ##
===================================================
- Coverage 96.39% 96.39% -0.01%
===================================================
Files 1402 1402
Lines 331865 332092 +227
Branches 11028 11057 +29
===================================================
+ Hits 319916 320130 +214
- Misses 9188 9194 +6
- Partials 2761 2768 +7 |
mavasani
approved these changes
Sep 16, 2023
ericstj
approved these changes
Sep 16, 2023
carlossanlop
removed
the
servicing-consider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6928 to release/8.0.1xx
/cc @carlossanlop
Fixes dotnet/runtime#89740
Customer Impact
The purpose of analyzer CA1862 is to determine if string comparisons (StartsWith, Contains, IndexOf, CompareTo, abd binary comparisons of string equality) are changing case and culture and suggest using other more performant methods that allow choosing a culture and casing handling properly. In some cases, the analyzer offers a fix, while in other cases it only offer a diagnosis and tells the user to manually determine what to do.
Unfortunately, the analyzer was changing semantics for some of the offered fixes, specifically those where the user was incorrectly comparing different cultures. This PR addresses that problem by avoiding offering fixes for those cases, and additionally improves the messages so that the user gets a more detailed explanation of the problem and what they need to do to address the problem manually.
Testing
Risk
Low. The analyzer is new and we're fixing specific cases while preserving the majority of correct ones.