Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directed Syntax Graph not working #327

Closed
vsfeedback opened this issue May 22, 2019 · 8 comments · Fixed by #542
Closed

Directed Syntax Graph not working #327

vsfeedback opened this issue May 22, 2019 · 8 comments · Fixed by #542

Comments

@vsfeedback
Copy link

VSF_TYPE_MARKDOWNWhen I open the syntax tree window and click on any node to view the directed syntax graph, Visual Studio 2019 crashes and restarts.

Eventlog:
Log Name:      Application
Source:        .NET Runtime
Date:          5/21/2019 1:45:59 PM
Event ID:      1026
Task Category: None
Level:         Error
Keywords:      Classic
User:          N/A
Computer:      FanieReynders
Description:
Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.Resources.MissingManifestResourceException
   at System.Resources.ManifestBasedResourceGroveler.HandleResourceStreamMissing(System.String)
   at System.Resources.ManifestBasedResourceGroveler.GrovelForResourceSet(System.Globalization.CultureInfo, System.Collections.Generic.Dictionary`2<System.String,System.Resources.ResourceSet>, Boolean, Boolean, System.Threading.StackCrawlMark ByRef)
   at System.Resources.ResourceManager.InternalGetResourceSet(System.Globalization.CultureInfo, Boolean, Boolean, System.Threading.StackCrawlMark ByRef)
   at System.Resources.ResourceManager.InternalGetResourceSet(System.Globalization.CultureInfo, Boolean, Boolean)
   at System.Resources.ResourceManager.GetString(System.String, System.Globalization.CultureInfo)
   at Roslyn.SyntaxVisualizer.DgmlHelper.My.Resources.Resources.get_SyntaxNodeLabel()
   at Roslyn.SyntaxVisualizer.DgmlHelper.SyntaxDgmlHelper.GetLabelForNode(Microsoft.CodeAnalysis.SyntaxNode)
   at Roslyn.SyntaxVisualizer.DgmlHelper.SyntaxDgmlHelper.ProcessNode(Roslyn.SyntaxVisualizer.DgmlHelper.SyntaxDgmlOptions, Microsoft.CodeAnalysis.SyntaxNode, System.Xml.Linq.XElement, Int32 ByRef, System.Xml.Linq.XElement, System.Xml.Linq.XElement, System.Collections.Generic.HashSet`1<System.String>)
   at Roslyn.SyntaxVisualizer.DgmlHelper.SyntaxDgmlHelper.ToDgml(Microsoft.CodeAnalysis.SyntaxNode, Roslyn.SyntaxVisualizer.DgmlHelper.SyntaxDgmlOptions)
   at Roslyn.SyntaxVisualizer.Extension.SyntaxVisualizerContainer.DisplaySyntaxNodeDgml(Microsoft.CodeAnalysis.SyntaxNode)
   at Roslyn.SyntaxVisualizer.Control.SyntaxVisualizerControl.DirectedSyntaxGraphMenuItem_Click(System.Object, System.Windows.RoutedEventArgs)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(System.Object, System.Windows.RoutedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(System.Object, System.Windows.RoutedEventArgs, Boolean)
   at System.Windows.UIElement.RaiseEventImpl(System.Windows.DependencyObject, System.Windows.RoutedEventArgs)
   at System.Windows.UIElement.RaiseEvent(System.Windows.RoutedEventArgs)
   at System.Windows.Controls.MenuItem.InvokeClickAfterRender(System.Object)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(System.Object)
   at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at MS.Internal.CulturePreservingExecutionContext.Run(MS.Internal.CulturePreservingExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
   at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)


-------

Log Name:      Application
Source:        Application Error
Date:          5/21/2019 1:46:00 PM
Event ID:      1000
Task Category: (100)
Level:         Error
Keywords:      Classic
User:          N/A
Computer:      FanieReynders
Description:
Faulting application name: devenv.exe, version: 16.0.28803.452, time stamp: 0x5cd5f87e
Faulting module name: KERNELBASE.dll, version: 10.0.17763.404, time stamp: 0x3424aead
Exception code: 0xe0434352
Fault offset: 0x0011c6f2
Faulting process id: 0x1658
Faulting application start time: 0x01d50fdb1efbf92e
Faulting application path: C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\devenv.exe
Faulting module path: C:\windows\System32\KERNELBASE.dll
Report Id: 0991b31a-b02c-462e-bfb0-6b4401c6cdf4
Faulting package full name: 
Faulting package-relative application ID:

This issue has been moved from https://developercommunity.visualstudio.com/content/problem/576259/directed-syntax-graph-not-working.html
VSTS ticketId: 896511

These are the original issue comments:

Visual Studio Feedback System on 5/22/2019, 02:13 AM (7 hours ago):

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

These are the original issue solutions:
(no solutions)

@tudort-iquest
Copy link

Any news on this issue? The View Directed Syntax Graph still causes a crash of VS 2019 , even in the latest version (16.4.0)

@bemayr
Copy link

bemayr commented Apr 8, 2020

In my case Visual Studio 2019 does not crash, it simply does nothing. Does anybody else have this problem?

Installed Plugins

  • Visual Studio extension development
  • DGML editor

Edit
Now it crashed as well (after a computer restart), after that same behavior as before.

Edit 2
added crashdump file

@Danghor
Copy link

Danghor commented Apr 8, 2020

It crashes on my machine as well, using Version 16.5.3 (April 7, 2020)

@FelixDamrau
Copy link

Still crashing in VS 16.5.4 and VS 16.6.0 preview 5

This seems to be a duplicate of issue #397

@liuxilu
Copy link

liuxilu commented Jun 2, 2020

On mine too. 16.6.1 Community
same call stack

@liuxilu
Copy link

liuxilu commented Jun 2, 2020

Change C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\Extensions\sb2m13sk.fu3\Roslyn.SyntaxVisualizer.DgmlHelper.dll!Roslyn.SyntaxVisualizer.DgmlHelper.My.Resources::Resources.get_SyntaxNodeLabel/get_SyntaxTokenLabel toreturn "Node {0}";andreturn "Token {0}"; using something like dnSpy, then things get work. And here's one copy.

Roslyn.SyntaxVisualizer.DgmlHelper.zip

For VS EULA, this operation has nothing to do with VS itself; For roslyn-sdk license, it's MIT.

sharwell added a commit to sharwell/roslyn-sdk that referenced this issue Jun 2, 2020
sharwell added a commit to sharwell/roslyn-sdk that referenced this issue Jun 3, 2020
@robinqiu
Copy link

robinqiu commented Jun 3, 2020

Change C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\Extensions\sb2m13sk.fu3\Roslyn.SyntaxVisualizer.DgmlHelper.dll!Roslyn.SyntaxVisualizer.DgmlHelper.My.Resources::Resources.get_SyntaxNodeLabel/get_SyntaxTokenLabel toreturn "Node {0}";andreturn "Token {0}"; using something like dnSpy, then things get work. And here's one copy.

Roslyn.SyntaxVisualizer.DgmlHelper.zip

For VS EULA, this operation has nothing to do with VS itself; For roslyn-sdk license, it's MIT.

Works for me, thanks!

sharwell added a commit to sharwell/roslyn-sdk that referenced this issue Jun 3, 2020
@sharwell sharwell added fixed and removed help wanted labels Jun 3, 2020
@sharwell sharwell self-assigned this Jun 3, 2020
@dronov-dmitry
Copy link

I have the same problem.
Syntax Visualiser is worked
https://prnt.sc/tbsi6b
but when i click "View dircted synax graph"
https://prnt.sc/tbsilm
it crashed
https://prnt.sc/tbsj2q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants