Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate source for Resources.resx #542

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jun 2, 2020

Supersedes #541

Fixes #327

@sharwell sharwell requested a review from a team as a code owner June 2, 2020 20:18
@sharwell
Copy link
Member Author

sharwell commented Jun 2, 2020

@jmarolf We can use either this or #541 to resolve bug #327.

@sharwell sharwell marked this pull request as draft June 3, 2020 00:13
@sharwell
Copy link
Member Author

sharwell commented Jun 3, 2020

@jmarolf I had to rewrite this to work around dotnet/arcade#5603. Highly recommend review with whitespace changes hidden.

@sharwell sharwell requested a review from jmarolf June 3, 2020 00:45
@sharwell sharwell marked this pull request as ready for review June 3, 2020 00:45
@sharwell sharwell marked this pull request as draft June 3, 2020 01:01
@sharwell sharwell marked this pull request as ready for review June 3, 2020 01:01
@sharwell sharwell merged commit 67f1277 into dotnet:master Jun 3, 2020
@sharwell sharwell deleted the generate-source branch June 3, 2020 17:30
@liuxilu
Copy link

liuxilu commented Jun 4, 2020

fix #397 #525 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directed Syntax Graph not working
3 participants