Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MissingManifestResourceException in DgmlHelper #541

Closed
wants to merge 1 commit into from
Closed

Fix MissingManifestResourceException in DgmlHelper #541

wants to merge 1 commit into from

Conversation

Danghor
Copy link

@Danghor Danghor commented Jun 2, 2020

Fixes a crash of the Directed Syntax Graph by using the correct base name for the ResourceManager.
Props to @liuxilu for nudging me in the right direction.

Fixes a crash of the Directed Syntax Graph by using the correct base name for the ResourceManager.
@Danghor Danghor requested a review from a team as a code owner June 2, 2020 19:58
@sharwell sharwell changed the title Fix #327 Fix MissingManifestResourceException in DgmlHelper Jun 2, 2020
@sharwell
Copy link
Member

sharwell commented Jun 2, 2020

I'm going to propose a slightly different way of doing this which will simplify future changes.

@sharwell
Copy link
Member

sharwell commented Jun 3, 2020

Superseded by #542

@sharwell sharwell closed this Jun 3, 2020
@sharwell
Copy link
Member

sharwell commented Jun 3, 2020

@Danghor Thank you for pushing us to get this fixed. I'm trying to get #542 merged today which would permanently resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants