Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename deconstruct_pattern to positional_pattern #32291

Closed
gafter opened this issue Jan 9, 2019 · 0 comments
Closed

Rename deconstruct_pattern to positional_pattern #32291

gafter opened this issue Jan 9, 2019 · 0 comments
Assignees
@gafter
Labels
Area-Compilers Bug Feature - Pattern Matching Pattern Matching
Milestone
16.0.P3

Comments

@gafter
Copy link
Member

gafter commented Jan 9, 2019

We should change both the spec grammar and the syntax nodes.
@gafter gafter added this to the 16.0.P2 milestone Jan 9, 2019
@gafter gafter self-assigned this Jan 9, 2019
@gafter gafter mentioned this issue Jan 14, 2019
Merged
gafter added a commit to gafter/roslyn that referenced this issue Jan 14, 2019
@gafter
Rename "deconstruct pattern" to "positional pattern" in the APIs.
acaa82c 
Fixes dotnet#32291
@gafter gafter modified the milestones: 16.0.P2, 16.0.P3 Jan 16, 2019
gafter pushed a commit that referenced this issue Jan 18, 2019
Syntax changes for recursive pattern-matching feature (#32432)
882f646 
* Rename "deconstruct pattern" to "positional pattern" in the APIs.
Fixes #32291

* Permit a trailing commas in two places
- Permit a trailing comma after the last arm of a switch expression
- Permit a trailing comma after the last subpattern of a property pattern clause
Fixes #32292
xoofx pushed a commit to stark-lang/stark-roslyn that referenced this issue Apr 16, 2019
Syntax changes for recursive pattern-matching feature (dotnet#32432)
d24f5d1 
* Rename "deconstruct pattern" to "positional pattern" in the APIs.
Fixes dotnet#32291

* Permit a trailing commas in two places
- Permit a trailing comma after the last arm of a switch expression
- Permit a trailing comma after the last subpattern of a property pattern clause
Fixes dotnet#32292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
Area-Compilers Bug Feature - Pattern Matching Pattern Matching
Projects
None yet
Milestone
16.0.P3
Development

No branches or pull requests
1 participant
@gafter